Skip to content

Commit

Permalink
.github/workflows/gha-ci.yml: add assrender, download xy-vsf and vsfm…
Browse files Browse the repository at this point in the history 
…od separately
  • Loading branch information
@MIRIMIRIM
MIRIMIRIM committed Aug 6, 2022
1 parent b8dfddd commit d5c132a
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion .github/workflows/gha-ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -181,15 +181,27 @@ jobs:
7z.exe x vendor/ffms2.zip -ovendor
Invoke-WebRequest -Uri https://github.com/AmusementClub/assrender/releases/download/0.37.1/assrender_v0371_0.16.0.zip -OutFile vendor/assrender.zip
Invoke-WebRequest -Uri https://github.com/HomeOfVapourSynthEvolution/xy-VSFilter/releases/download/r3/xy-VSFilter-r3.7z -OutFile vendor/xy-vsf.7z
Invoke-WebRequest -Uri https://github.com/Masaiki/VSFilterMod/releases/download/r5.2.7/VSFilterMod_bin.zip -OutFile vendor/vsfmod.zip
7z.exe x vendor/assrender.zip -ovendor
7z.exe x vendor/xy-vsf.7z -ovendor
7z.exe x vendor/vsfmod.zip -ovendor
Move-Item -Path build-dir\Release\Aegisub.exe -Destination build-dir\Aegisub.exe
Remove-Item -Path build-dir\Release\*.exp,build-dir\Release\*.lib,build-dir\Release\*.exe
Move-Item -Path build-dir\Aegisub.exe -Destination build-dir\Release\Aegisub.exe
New-Item -Path build-dir\Release\automation -ItemType directory
Copy-Item -Path automation\autoload,automation\demos,automation\include -Destination build-dir\Release\automation -Recurse
New-Item -Path build-dir\Release\csri -ItemType directory
Copy-Item -Path C:\vcpkg\installed\x64-windows-release\bin\AviSynth.dll -Destination build-dir\Release
Copy-Item -Path vendor\ffms2.dll -Destination build-dir\Release
Copy-Item -Path vendor\aegisub9212\csri,vendor\aegisub9212\dictionaries,vendor\aegisub9212\licenses,vendor\aegisub9212\locale,vendor\aegisub9212\AssDraw3.exe,vendor\aegisub9212\AssDraw3.chm,vendor\aegisub9212\DirectShowSource.dll -Destination build-dir\Release -Recurse
Copy-Item -Path vendor\x64\*.dll -Destination build-dir\Release\csri
Copy-Item -Path vendor\plugins64\xy-VSFilter.dll -Destination build-dir\Release\csri
Copy-Item -Path vendor\aegisub9212\dictionaries,vendor\aegisub9212\licenses,vendor\aegisub9212\locale,vendor\aegisub9212\AssDraw3.exe,vendor\aegisub9212\AssDraw3.chm,vendor\aegisub9212\DirectShowSource.dll -Destination build-dir\Release -Recurse
- name: upload artifact
uses: actions/upload-artifact@v2
Expand Down

11 comments on commit d5c132a

@kedaitinh12
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest vsfiltermod here:
https://github.com/computerfan/VSFilterMod/releases

@MIRIMIRIM
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest vsfiltermod here: https://github.com/computerfan/VSFilterMod/releases

I know this, but I don’t need new mod asstags for now.

@kedaitinh12
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest vsfiltermod here: https://github.com/computerfan/VSFilterMod/releases

I know this, but I don’t need new mod asstags for now.

oh, but your ver had issue after apply karaoke template
Runtime error in template code: Expected 1 arguments, got 2
Code producing error: ci = { 0,0 }; cn = _G.unicode.len(orgline.text_stripped:gsub(" ",""))

Upstream ver don't had this error.
My file sub: https://mega.nz/file/15h3SAaL#ssV3j4zU5AcJmBPM39s3Fm6FKMGGf6V9ukS6Vdvi9zw

@MIRIMIRIM
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest vsfiltermod here: https://github.com/computerfan/VSFilterMod/releases

I know this, but I don’t need new mod asstags for now.

oh, but your ver had issue after apply karaoke template Runtime error in template code: Expected 1 arguments, got 2 Code producing error: ci = { 0,0 }; cn = _G.unicode.len(orgline.text_stripped:gsub(" ",""))

Upstream ver don't had this error. My file sub: https://mega.nz/file/15h3SAaL#ssV3j4zU5AcJmBPM39s3Fm6FKMGGf6V9ukS6Vdvi9zw

Thank you for the error information, we will check it.

@MIRIMIRIM
Copy link
Author

@MIRIMIRIM MIRIMIRIM commented on d5c132a Aug 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kedaitinh12

I tried aegisub wangqr fork 3.3.3 and it has the same error when apply, I wonder if you can provide specific version information.

@kedaitinh12
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kedaitinh12

I tried aegisub wangqr fork 3.3.3 and it has the same error when apply, I wonder if you can provide specific version information.

That ver
https://github.com/Aegisub/Aegisub/releases

@MIRIMIRIM
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kedaitinh12

I found this issue: Aegisub#96, all of the latest builds now have this issue, maybe something has changed in lua.
You can use _G.unicode.len((orgline.text_stripped:gsub(" ",""))) instead of _G.unicode.len(orgline.text_stripped:gsub(" ",""))

@kedaitinh12
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kedaitinh12

I found this issue: Aegisub#96, all of the latest builds now have this issue, maybe something has changed in lua. You can use _G.unicode.len((orgline.text_stripped:gsub(" ",""))) instead of _G.unicode.len(orgline.text_stripped:gsub(" ",""))

But Kainote fixed it, can you base Kainote to fix it??
https://github.com/bjakja/Kainote

@AkarinVS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is "caused" by this commit (e3c60514cd#diff-06242792b0c4ad8019226b580d45811c7beb1c54afa4e832a2e9b4b4e5628831L70) which adds argument type checks for _G.unicode.len and others.

In theory we can "fix" it by disabling the argument type check, but I'm not sure that's the way we should go.
The issue is that the code _G.unicode.len(orgline.text_stripped:gsub(" ","")) has always been incorrect; _G.unicode.len() only takes one argument, but string.gsub always return two; You can add another pair of parentheses to force one argument as mentioned by @MIRIMIRIM above.

@kedaitinh12
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok

@kedaitinh12
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove argument type checks for _G.unicode.len in new commit cause i don't see any error if ignored it in old ver

Please sign in to comment.