Fix #15: Improve Auto complete drop down position when cursor on the …

…end of the visible view
AmrDeveloper · Feb 27, 2022 · 58be534 · 58be534
1 parent c077612
commit 58be534
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/codeview/src/main/java/com/amrdeveloper/codeview/CodeView.java b/codeview/src/main/java/com/amrdeveloper/codeview/CodeView.java
@@ -648,9 +648,6 @@ public void showDropDown() {
         final int[] screenPoint = new int[2];
         getLocationOnScreen(screenPoint);
 
-        final Rect displayFrame = new Rect();
-        getWindowVisibleDisplayFrame(displayFrame);
-
         final Layout layout = getLayout();
         final int position = getSelectionStart();
         final int line = layout.getLineForOffset(position);
@@ -667,8 +664,17 @@ public void showDropDown() {
             dropDownHeight = modifiedDropDownHeight;
         }
 
+        final Rect displayFrame = new Rect();
+        getWindowVisibleDisplayFrame(displayFrame);
+        int displayFrameHeight = displayFrame.height();
+
+        int verticalOffset = lineButton + dropDownHeight;
+        if (verticalOffset > displayFrameHeight) {
+            verticalOffset = displayFrameHeight - autoCompleteItemHeightInDp;
+        }
+
         setDropDownHeight(dropDownHeight);
-        setDropDownVerticalOffset(lineButton + dropDownHeight);
+        setDropDownVerticalOffset(verticalOffset);
         setDropDownHorizontalOffset((int) layout.getPrimaryHorizontal(position));
 
         super.showDropDown();