Updating dataMode in beginTransaction() #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-accepting the member (_dataMode) of user argument SPISettings -updating library variable dataMode before sending that to spi_format().
1 task
|
Hi @M-ichae-l , When do you think you will do a new release? |
|
I believed that the latest early release is done last week. https://github.com/ambiot/ambd_arduino/releases/tag/V3.1.8-QC-V02 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Arduino libraries should update SPI settings when beginTransaction() is called with a complete struct of SPISettings is passed in as an argument.
Tests and Environments
This PR fixes issue #239