Skip to content

Commit

Permalink
fix Spark-version-based build CI
Browse files Browse the repository at this point in the history
The current version writes the Spark version to a file that is not read anymore. It needs to be replaced with the proper SBT command.
  • Loading branch information
marclamy committed Apr 15, 2024
1 parent 8142d26 commit 6472211
Showing 1 changed file with 9 additions and 11 deletions.
20 changes: 9 additions & 11 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ on:
required: true

jobs:
spark_versions_validation:
spark-versions-validation:
if: ${{ github.event_name != 'workflow_dispatch' }}
strategy:
matrix:
spark_version: ['3.2.4', '3.3.2', '3.4.1']
spark_version: ['3.4.1', '3.5.0']
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -32,26 +32,24 @@ jobs:
distribution: "temurin"
cache: "sbt"
- env:
SPARK_VERSION_OVERRIDE: ${{ matrix.spark_version }}
run: |
echo "$SPARK_VERSION_OVERRIDE" > project/spark-version.conf
- run: cat project/spark-version.conf
SPARK_VERSION: ${{ matrix.spark-version }}
run: echo "SPARK_VERSION_OVERRIDE=${SPARK_VERSION}" >> $GITHUB_ENV
- run: sbt compile
- run: sbt test

build:
runs-on: ubuntu-latest
env:
SPARK_VERSION_OVERRIDE: ${{ inputs.spark-version }}
steps:
- uses: actions/checkout@v4
- uses: actions/setup-java@v3
with:
java-version: 8
distribution: "temurin"
cache: "sbt"
- if: ${{ env.SPARK_VERSION_OVERRIDE != '' }}
run: echo "$SPARK_VERSION_OVERRIDE" > project/spark-version.conf
- if: ${{ github.event.inputs.spark-version != '' }}
env:
SPARK_VERSION: ${{ inputs.spark-version }}
run: echo "SPARK_VERSION_OVERRIDE=${SPARK_VERSION}" >> $GITHUB_ENV
- run: sbt compile
- run: sbt test
- run: sbt package
Expand All @@ -61,4 +59,4 @@ jobs:
name: Artefacts
path: artefacts.tar

run-name: ${{ github.event_name == 'workflow_dispatch' && format('Building for Spark {0}', inputs.spark-version) || ' '}}
run-name: ${{ github.event_name == 'workflow_dispatch' && format('Building for Spark {0}', inputs.spark-version) || ' '}}

0 comments on commit 6472211

Please sign in to comment.