Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add ITK helpers for streaming SmartSPIM subimages #4

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

tbirdso
Copy link
Contributor

@tbirdso tbirdso commented Aug 16, 2023

Provides scripts and demonstrates procedure for working with SmartSPIM images in ITK:

  1. Compose multiresolution image metadata from OME-Zarr standard header and acquisition.json bespoke header
  2. Retrieve image regions of interest from the cloud with physically correct metadata

Code changes:

  • Adds helper scripts in image.py and smartspim.py for retrieving SmartSPIM physical metadata and translating between physical and voxel domains
  • Adds example StreamSmartSPIM.ipynb notebook describing procedure for streaming SmartSPIM images with ITK tools

image

image

Copy link
Collaborator

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbirdso beautiful!! ✨ 💖

LGTM! A few minor comments inline.

CC @lydiang

src/aind_ccf_alignment_experiments/image.py Show resolved Hide resolved
src/aind_ccf_alignment_experiments/image.py Outdated Show resolved Hide resolved
@tbirdso tbirdso requested a review from lydiang August 16, 2023 19:25
tbirdso added a commit that referenced this pull request Aug 16, 2023
Changes:
- Adds helper scripts in `image.py` and `smartspim.py` for retrieving
  SmartSPIM physical metadata and translating between physical and voxel
  domains
- Adds example `StreamSmartSPIM.ipynb` notebook describing how to stream
  SmartSPIM data with ITK tools
- Moves image methods from `registration_methods.py` to `image.py`
@tbirdso
Copy link
Contributor Author

tbirdso commented Aug 18, 2023

Squashed fixups.

@tbirdso
Copy link
Contributor Author

tbirdso commented Aug 18, 2023

Moving forward with merge to support related development.

@tbirdso tbirdso merged commit 86962d4 into main Aug 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants