Store the file edit backup file in /tmp
#3958
Open
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobitege
reviewed
Sep 19, 2024
| @@ -512,9 +512,11 @@ def _edit_file_impl( | |||
| if enable_auto_lint: | |||
| # BACKUP the original file | |||
| original_file_backup_path = os.path.join( | |||
| '/tmp', | |||
There was a problem hiding this comment.
If going temp, why not use tempfile.TemporaryDirectory() instead of /tmp+dirname?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the problem this fixes or functionality that this introduces. This may be used for the CHANGELOG
Existing agentskills' editing store backup file in the same directory, which sometimes messes up the
git patchproduced for SWE-Bench evaluation (not in terms of accuracy, but in terms of size).Give a summary of what the PR does, explaining any non-trivial design decisions
This PR stores those tmp file under
/tmpinstead of the same directory.Link of any specific issues this addresses