Fix restore cli sessions #3409
Merged
Fix restore cli sessions #3409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enyst
force-pushed
the
enyst/cli-sessions-fix
branch
from
2cb0eac
to
cdcd70f
Compare
enyst
force-pushed
the
enyst/cli-sessions-fix
branch
from
a062b5b
to
31749fc
Compare
enyst
force-pushed
the
enyst/cli-sessions-fix
branch
from
31749fc
to
5014d93
Compare
|
Clicking Update branch so the new required jobs run |
|
Thanks! 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no issues posted, but this is a fix for a real issue: cannot restore history from the event stream if running headless.
This PR proposes a fix that keeps it simple but is starting to introduce a bit of flexibility in handling command-line sessions:
Maybe sometime we'll want a real cli client, this is just a bit on the road. 😄
Note: this only concerns the sid that is used as name for the event stream. All uses of
create_runtimein evals create their ownsidtoo and send it, so we fix the uniqueness of their respective event stream from there. This PR doesn't change that for the container name there is more unique stuff added.