Split Frontend and Python Unit tests #3399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobitege
reviewed
Aug 15, 2024
tobitege
reviewed
Aug 15, 2024
|
I've asked Robert to help me with the required tests. Since I changed the name, it will need to be readjusted before and after this merges |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
The split isn't quite necessary but it's a quality of life improvement. Just makes following the different workflows easier.
The real change is: Always run all unit tests. This is a minimum test that should always be run, especially on main (This was being skipped on main pushes that only had the paths-ignore changes.)
Give a summary of what the PR does, explaining any non-trivial design decisions
Other references