feat: convert agent prompts into structured Jinja2 templates #3360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-boxuan
reviewed
Aug 18, 2024
enyst
reviewed
Aug 18, 2024
Co-authored-by: Engel Nyst <[email protected]>
enyst
reviewed
Aug 18, 2024
|
|
||
|
|
||
| class CodeActAgent(Agent): | ||
| VERSION = '1.8' | ||
| VERSION = '1.9' |
There was a problem hiding this comment.
Just to note, it's not obvious to me from the diff (looking on GitHub) that the prompt as sent to the llm really did change. But 1.9 is ok anyway, it's probably overdue.
There was a problem hiding this comment.
OK, it did change, though not a lot.
|
This looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
This is part of the new micro-agent proposal: #3444
Give a summary of what the PR does, explaining any non-trivial design decisions
PromptManagerthat takes in a prompt directory,agentskilldocumentations, and optionally a micro-agent name. It will use Jinja2 template to generate the system message and first user message for CodeAct agent. See [Agent Framework] New microagents implementation #3444 for more details.Other references