agent_controller: in PAUSED state reduce delegate logspam from delega…

…te (#3946)
All-Hands-AI · Sep 19, 2024 · 620526b · 620526b
1 parent 31dbd3d
commit 620526b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/agenthub/browsing_agent/prompt.py b/agenthub/browsing_agent/prompt.py
@@ -57,7 +57,7 @@ def asdict(self):
 
     @classmethod
     def from_dict(self, flags_dict):
-        """Helper for JSON serializble requirement."""
+        """Helper for JSON serializable requirement."""
         if isinstance(flags_dict, Flags):
             return flags_dict
 

diff --git a/openhands/controller/agent_controller.py b/openhands/controller/agent_controller.py
@@ -383,7 +383,10 @@ async def _step(self) -> None:
 
         if self.delegate is not None:
             assert self.delegate != self
-            await self._delegate_step()
+            if self.delegate.get_agent_state() == AgentState.PAUSED:
+                await asyncio.sleep(1)
+            else:
+                await self._delegate_step()
             return
 
         logger.info(
@@ -458,7 +461,7 @@ async def _delegate_step(self):
             self.delegate = None
             self.delegateAction = None
 
-            await self.report_error('Delegator agent encounters an error')
+            await self.report_error('Delegator agent encountered an error')
         elif delegate_state in (AgentState.FINISHED, AgentState.REJECTED):
             logger.info(
                 f'[Agent Controller {self.id}] Delegate agent has finished execution'