Merge pull request ClickHouse#69676 from ClickHouse/hanfei/fix-create…

…-as-with-recursive fix bug about `CREATE ... AS WITH RECURSIVE`
Alex-Cheng · Oct 1, 2024 · 5257422 · 5257422
2 parents 963d3f4 + 1661f99
commit 5257422
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/src/Interpreters/AddDefaultDatabaseVisitor.h b/src/Interpreters/AddDefaultDatabaseVisitor.h
@@ -121,7 +121,10 @@ class AddDefaultDatabaseVisitor
     {
         if (select.recursive_with)
             for (const auto & child : select.with()->children)
-                with_aliases.insert(child->as<ASTWithElement>()->name);
+            {
+                if (typeid_cast<ASTWithElement *>(child.get()))
+                    with_aliases.insert(child->as<ASTWithElement>()->name);
+            }
 
         if (select.tables())
             tryVisit<ASTTablesInSelectQuery>(select.refTables());

diff --git a/tests/queries/0_stateless/03237_create_table_select_as_with_recursive.reference b/tests/queries/0_stateless/03237_create_table_select_as_with_recursive.reference
diff --git a/tests/queries/0_stateless/03237_create_table_select_as_with_recursive.sql b/tests/queries/0_stateless/03237_create_table_select_as_with_recursive.sql
@@ -0,0 +1,10 @@
+drop table if exists t;
+SET enable_analyzer = 1;
+create table t1 (a Int64, s DateTime('Asia/Istanbul')) Engine = MergeTree() ORDER BY a;
+create view t AS (
+    WITH RECURSIVE 42 as ttt,
+    toDate(s) as start_date,
+    _table as (select 1 as number union all select number + 1 from _table where number < 10)
+    SELECT a, ttt from t1 join _table on t1.a = _table.number and start_date = '2024-09-23'
+);
+drop table t;