Replace MySQL build with SQLite #3042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3042 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 237 237
Lines 6405 6405
=======================================
Hits 6179 6179
Misses 226 226 ☔ View full report in Codecov by Sentry. |
We already test with MariaDB - the Open Source MySQL fork. Since MySQL 5.7 support has been stopped in Nov 23 we remove precious build minutes for it. Using these build minutes for testing SQLite - a database that will have full production support with Rails 8.0
tvdeyen
force-pushed
the
remove-mysql-build
branch
from
2f216ba
to
77f5d36
Compare
sascha-karnatz
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
We already test with MariaDB - the Open Source MySQL fork. Since MySQL 5.7 support has been stopped in Nov 23 we remove precious build minutes for it.
Using these build minutes for testing SQLite - a database that will have full production support with Rails 8.0
Checklist