Improve etag generation #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
use-updated-at-for-etag
branch
from
1bf0c2d
to
761dc59
Compare
mamhoff
force-pushed
the
use-updated-at-for-etag
branch
3 times, most recently
from
80b2f07
to
9343574
Compare
mamhoff
force-pushed
the
use-updated-at-for-etag
branch
3 times, most recently
from
7d79b01
to
4adc593
Compare
The Last-Modified header is a weaker cache key than the etag, and thus we rely solely on the etag from now on. Browsers and Rails will ignore it if it's not set while validating if a request is fresh. Also sets the etag based on JSONAPI's typical set of params, so that we get a different etag for different `include`, `sort`, `page`, `fields`, or `filter` params.
mamhoff
force-pushed
the
use-updated-at-for-etag
branch
from
4adc593
to
230fdea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Last-Modified header is a weaker cache key than the etag, and thus
we rely solely on the etag from now on. Browsers and Rails will ignore
it if it's not set while validating if a request is fresh.