Some changes in the docs for advanced transitions #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v-tooltip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
The classes for the hiding transition are wrong in the table in https://floating-vue.starpad.dev/guide/css#advanced-transitions, so I changed them accordingly.
Also, I realized that if you follow the docs and change the transition of
.v-popper__wrapper, you also have to change the transition of its parent (.v-popper__popper). So if your transition takes .5 seconds for example, you wouldn't be able to see the whole transition because of the parent's transition that takes only .15 seconds.You can see an example of this in this stackblitz: https://stackblitz.com/edit/vue-fyqfc2?file=src%2FApp.vue,src%2Fmain.js
So I added a little note about it. I'm not sure if I explained it well and if it needs to be in the docs, but it probably would have saved me some time.