Fix flakiness in test_backup_and_restore_fail_on_disk_full #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathia-barahona
commented
Aug 9, 2023
Comment on lines
-29
to
-32
| # Delete all files in the tmpfs filesystem before unmounting it. | ||
| with suppress(Exception): | ||
| LocalPath(sub_dir).remove(rec=1) | ||
| subprocess.check_call(["sudo", "umount", str(sub_dir)]) |
There was a problem hiding this comment.
ended up removing this, because it was raising an exception and pytest was complaining since it was not able to delete temporary directories
kathia-barahona
force-pushed
the
fix_flaky_full_on_disk_test
branch
2 times, most recently
from
484e2b9
to
6685f05
Compare
…sk full message in test_backup_and_restore_fail_on_disk_full. [BF-2161]
kathia-barahona
force-pushed
the
fix_flaky_full_on_disk_test
branch
from
6685f05
to
007d83b
Compare
packi
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/local/test_controller.py::test_backup_and_restore_fail_on_disk_fullwas failing due to a race condition. Now it waits till the coordinator reachesfailedphase and afterwards checks for disk full log.[BF-2161]