refactor docker file, fixes filter bug [fixes OSRA-468] #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to_sponsors_scopes Add order to sponsor scopes
Add branding
Payments model
Refactor Sponsorship
…t_to_sponsor_cb Osra 453 add payment to sponsor cashbox
…ndencies Update dependencies
…ip-s3-config Fix paperclip s3 config
Replace s3_host_domain config with url & path config for Paperclip
dockerize app
b264
reviewed
Jun 5, 2017
| @orphans_before_paginate = Orphan.with_filter_fields.filter(@filters). | ||
| order(@current_sort_column.to_s + " " + @current_sort_direction.to_s) | ||
| @orphans_before_paginate = Orphan.with_filter_fields.filter(@filters) | ||
| .order(@current_sort_column.to_s + " " + @current_sort_direction.to_s) |
There was a problem hiding this comment.
In Ruby, I feel it's better to have these at the end. You can't copy & paste this into rails console now. Why the change? Not trying to bikeshed; just curious
There was a problem hiding this comment.
sorry I forgot to revert this on previous state 😞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://osraav.atlassian.net/browse/OSRA-468