Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix java 11 warning for DialogProviderAnnotationProcessor - Fixes #3187 #3233

Conversation

henrykuijpers
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (81a8041) 55.21% compared to head (4e65fe7) 1.34%.

Files Patch % Lines
...e/acs/commons/mcp/form/DialogResourceProvider.java 0.00% 4 Missing ⚠️
...ns/mcp/form/DialogProviderAnnotationProcessor.java 96.96% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #3233       +/-   ##
============================================
- Coverage     55.21%   1.34%   -53.87%     
+ Complexity     5476      44     -5432     
============================================
  Files           721     721               
  Lines         29526   29537       +11     
  Branches       3844    3844               
============================================
- Hits          16302     397    -15905     
- Misses        11697   29124    +17427     
+ Partials       1527      16     -1511     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henrykuijpers
Copy link
Contributor Author

@davidjgonzalez Wanna merge this in? :D Or any other action required?

@davidjgonzalez davidjgonzalez merged commit 6649768 into Adobe-Consulting-Services:master Jan 16, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants