Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3177 - Automate creation of vanity URLs for each country & lang… #3179

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

yelouardi
Copy link
Contributor

…uage

@yelouardi yelouardi force-pushed the issues/3177-automate-creation-vanity branch from 8850a78 to 980d6f3 Compare September 14, 2023 14:31
@yelouardi yelouardi force-pushed the issues/3177-automate-creation-vanity branch from 5723f9b to d8e5cf3 Compare September 14, 2023 15:44
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (6e88e55) 55.23% compared to head (9b1da0b) 55.24%.
Report is 16 commits behind head on master.

❗ Current head 9b1da0b differs from pull request most recent head f3bcd98. Consider uploading reports for the commit f3bcd98 to get more accurate results

Files Patch % Lines
...acs/commons/redirectmaps/impl/AddEntryServlet.java 73.68% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3179      +/-   ##
============================================
+ Coverage     55.23%   55.24%   +0.01%     
- Complexity     5469     5471       +2     
============================================
  Files           720      720              
  Lines         29497    29515      +18     
  Branches       3837     3843       +6     
============================================
+ Hits          16293    16306      +13     
- Misses        11681    11682       +1     
- Partials       1523     1527       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yelouardi
Copy link
Contributor Author

Hi @davidjgonzalez can you check please my dev ?
Thank you

@yelouardi
Copy link
Contributor Author

Hi @rombert @davidjgonzalez
Can you please review my PR ?
Thank you

@davidjgonzalez
Copy link
Contributor

davidjgonzalez commented Oct 10, 2023

@yelouardi - can you describe what this does exactly, and what usecase your tackling?

It seems like it

Uses a generic list whose items are in the format:

 + item-1
     + jcr:title: lang code (ex. en)
     + value: country code (ex. us)

Turns this into a map (so i guess this list can have only 1 item for each country?)

Then assuming there are countries, adds the redirect entries for each country/lang?

Or does this ONLY support countries and not langs?

Its hard to tell since the tests dont have representative real-life params.

@davidjgonzalez davidjgonzalez added the need more info Issue requires more information label Oct 10, 2023
@yelouardi
Copy link
Contributor Author

yelouardi commented Oct 19, 2023

Hi @davidjgonzalez
Thank you

Turns this into a map (so i guess this list can have only 1 item for each country?) : YES

Then assuming there are countries, adds the redirect entries for each country/lang? Each pays has one country language Master

Or does this ONLY support countries and not langs? YES

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need more info Issue requires more information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants