Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3138 Support for case insensitive redirect rules #3153

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

YegorKozlov
Copy link
Contributor

#3150

The PR adds support for case insensitive redirect rules.
There is a new boolean flag in the configuration dialog. If checked , then the rule is evaluated in case-insensitive manner.
image

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #3153 (2087253) into master (768bb4c) will increase coverage by 0.01%.
Report is 6 commits behind head on master.
The diff coverage is 93.18%.

❗ Current head 2087253 differs from pull request most recent head d8f9c5b. Consider uploading reports for the commit d8f9c5b to get more accurate results

@@             Coverage Diff              @@
##             master    #3153      +/-   ##
============================================
+ Coverage     55.18%   55.20%   +0.01%     
- Complexity     5405     5410       +5     
============================================
  Files           711      711              
  Lines         28988    29003      +15     
  Branches       3745     3749       +4     
============================================
+ Hits          15997    16010      +13     
  Misses        11488    11488              
- Partials       1503     1505       +2     
Files Changed Coverage Δ
...e/acs/commons/redirects/filter/RedirectFilter.java 77.60% <66.66%> (-0.13%) ⬇️
...ommons/redirects/models/RedirectConfiguration.java 87.83% <93.33%> (+1.27%) ⬆️
...ns/remoteassets/impl/RemoteAssetsNodeSyncImpl.java 86.94% <95.00%> (-0.30%) ⬇️
...obe/acs/commons/redirects/models/RedirectRule.java 82.92% <100.00%> (+0.87%) ⬆️

@davidjgonzalez davidjgonzalez merged commit 4faab41 into Adobe-Consulting-Services:master Aug 7, 2023
18 checks passed
YegorKozlov added a commit to YegorKozlov/acs-aem-commons that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants