HCI/ACL fragmentation and flow control #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
hci
branch
2 times, most recently
from
b96c26d
to
81dd643
Compare
bugadani
commented
May 27, 2024
|
|
||
| def writeOneAclDataPkt(self): | ||
| pkt = self._aclOutQueue.pop(0) | ||
| if pkt["handle"] not in self._handleAclsInProgress: |
There was a problem hiding this comment.
This is not part of bleno, but notifications aren't unsubscribed when the central disconnects, so without this check we would end up throwing exceptions every time a (notified) characteristic value changes after disconnection. Not a proper fix, but good enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the following commits:
abandonware/bleno@16b9ebe
abandonware/bleno@916a291
abandonware/bleno@06f5b2d
This patch is necessary for pybleno to work correctly on the Raspberry Pi Zero 2 W.