Merge branch 'topic/exemption_rule_name' into 'master'

Correct the regular expression matching rule names in annotation pragmas Closes #328 See merge request eng/libadalang/langkit-query-language!287
AdaCore · Sep 3, 2024 · 51e93de · 51e93de
2 parents 9d96c92 + b0a6598
commit 51e93de
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lkql_checker/doc/gnatcheck_rm/using_gnatcheck.rst b/lkql_checker/doc/gnatcheck_rm/using_gnatcheck.rst
@@ -515,6 +515,12 @@ to simplify mapping your coding standard requirements onto
     ...
     bar.ads:17:3: this is not good [My_Coding_Rule_N|Gnatcheck_Rule_N]
 
+.. attention::
+
+  A custom coding rule name can be any sequence of non-whitespace characters.
+  Moreover, the ":" (colon) character is forbidden in those names for parsing
+  purposes.
+
 .. _gnatcheck_Exit_Codes:
 
 GNATcheck Exit Codes

diff --git a/lkql_checker/src/gnatcheck-diagnoses.adb b/lkql_checker/src/gnatcheck-diagnoses.adb
@@ -44,7 +44,7 @@ package body Gnatcheck.Diagnoses is
    --  Matcher for a diagnostic
 
    Match_Rule_Name : constant Pattern_Matcher :=
-     Compile ("^""(\w+)\s*(?::\s*(.*))?""$");
+     Compile ("^""([^\s:]+)\s*(?::\s*(.*))?""$");
    --  Matcher for a rule name and potential arguments
 
    Match_Rule_Param : constant Pattern_Matcher :=