Skip to content

Commit

Permalink
Enable runtime
Browse files Browse the repository at this point in the history
  • Loading branch information
MDrakos committed Nov 30, 2023
1 parent af176b3 commit f01d400
Show file tree
Hide file tree
Showing 2 changed files with 57 additions and 1 deletion.
53 changes: 53 additions & 0 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
name: golangci-lint
on:
pull_request:
types:
- opened
- synchronize
- reopened
- ready_for_review

permissions:
contents: read
# Optional: allow read access to pull request. Use with `only-new-issues` option.
# pull-requests: read

jobs:
golangci:
name: lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: '1.20'
cache: false
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
# Require: The version of golangci-lint to use.
# When `install-mode` is `binary` (default) the value can be v1.2 or v1.2.3 or `latest` to use the latest version.
# When `install-mode` is `goinstall` the value can be v1.2.3, `latest`, or the hash of a commit.
version: v1.54

# Optional: golangci-lint command line arguments.
#
# Note: By default, the `.golangci.yml` file should be at the root of the repository.
# The location of the configuration file can be changed by using `--config=`
# args: --timeout=30m --config=/my/path/.golangci.yml --issues-exit-code=0

# Optional: show only new issues if it's a pull request. The default value is `false`.
# only-new-issues: true

# Optional: if set to true, then all caching functionality will be completely disabled,
# takes precedence over all other caching options.
# skip-cache: true

# Optional: if set to true, then the action won't cache or restore ~/go/pkg.
# skip-pkg-cache: true

# Optional: if set to true, then the action won't cache or restore ~/.cache/go-build.
# skip-build-cache: true

# Optional: The mode to install golangci-lint. It can be 'binary' or 'goinstall'.
# install-mode: "goinstall"
5 changes: 4 additions & 1 deletion test/integration/install_int_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,10 @@ func (suite *InstallIntegrationTestSuite) TestInstall_BuildPlannerError() {
defer ts.Close()

ts.PrepareProject("ActiveState-CLI/small-python", "d8f26b91-899c-4d50-8310-2c338786aa0f")
cp := ts.SpawnWithOpts(e2e.OptArgs("install", "[email protected]"), e2e.OptAppendEnv(constants.DisableRuntime+"=true"))
cp := ts.SpawnWithOpts(
e2e.OptArgs("install", "[email protected]"),
e2e.OptAppendEnv(constants.DisableRuntime+"=false"),
)
cp.Expect("Could not plan build, platform responded with", e2e.RuntimeSourcingTimeoutOpt)
cp.ExpectExitCode(1)
ts.IgnoreLogErrors()
Expand Down

0 comments on commit f01d400

Please sign in to comment.