-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VDB 12.0.0 Release #1958
VDB 12.0.0 Release #1958
Conversation
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
openvdb/openvdb/openvdb.cc
Outdated
#ifndef OPENVDB_USE_FUTURE_ABI_12 | ||
#if OPENVDB_ABI_VERSION_NUMBER == 12 | ||
#ifndef OPENVDB_USE_FUTURE_ABI_13 | ||
#if OPENVDB_ABI_VERSION_NUMBER == 13 | ||
#error ABI = 12 is still in active development and has not been finalized, \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the error should be ABI = 13 is still in active development.
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
…ions Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments. Other than my comment on setting the minimum NanoBind version, everything else looks good. Once all the CIs passed, this looks good.
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Can you still build with ABI=11 and the old C++ ABI? |
Yes, it still works. In fact the only thing we do regarding ABI currently is trying to align with Houdini's ABI (https://github.com/AcademySoftwareFoundation/openvdb/blob/master/cmake/OpenVDBHoudiniSetup.cmake#L349) and I didn't remove that logic in this release. Otherwise, you get whatever the compiler/compiler flags request. However, it's not guaranteed to continue working. I removed all the CI jobs that test with GCC 9 / ABI=0 and if you build with GCC 9, you'll get a warning that it is unsupported which you have to suppress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments about the llvm ci, otherwise lgtm, thanks a lot @danrbailey
Signed-off-by: Dan Bailey <[email protected]>
The release branch for VDB 12.0.0. This bumps the version up, updates the change log and makes a small fix to the CI docs workflow.
This also bumps up a number of minimum versions for our dependencies. We now support the VFX Reference Platforms 2023, 2024, 2025. These are the most notable version bumps:
I have also updated the CI accordingly. Finally, the address sanitizer picked up a bug in the RootNode, which I have also fixed (using emplace for an existing element in one case).