ci: unbreak CI for OIIO auto-build of OCIO for icx case #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some explanation is needed: OIIO master recently added the ability to auto-build OCIO when a new enough one is not found at its build time, and bumped the minimum OCIO to 2.2. Sometimes this is triggered by OSL's CI, when OCIO < 2.2, so building OIIO also triggers building of OCIO. All fine, except for the case when we are testing Intel's icx compiler, which OCIO's build system does not recognize and fails to build. So we make a little modification here that lets us, just for that case, ensure that OCIO is pre-built with gcc even though we're building OIIO and OSL with icx. Signed-off-by: Larry Gritz <[email protected]>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Aug 19, 2024
…areFoundation#1849) Some explanation is needed: OIIO master recently added the ability to auto-build OCIO when a new enough one is not found at its build time, and bumped the minimum OCIO to 2.2. Sometimes this is triggered by OSL's CI, when OCIO < 2.2, so building OIIO also triggers building of OCIO. All fine, except for the case when we are testing Intel's icx compiler, which OCIO's build system does not recognize and fails to build. So we make a little modification here that lets us, just for that case, ensure that OCIO is pre-built with gcc even though we're building OIIO and OSL with icx. Signed-off-by: Larry Gritz <[email protected]>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Aug 19, 2024
…areFoundation#1849) Some explanation is needed: OIIO master recently added the ability to auto-build OCIO when a new enough one is not found at its build time, and bumped the minimum OCIO to 2.2. Sometimes this is triggered by OSL's CI, when OCIO < 2.2, so building OIIO also triggers building of OCIO. All fine, except for the case when we are testing Intel's icx compiler, which OCIO's build system does not recognize and fails to build. So we make a little modification here that lets us, just for that case, ensure that OCIO is pre-built with gcc even though we're building OIIO and OSL with icx. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some explanation is needed:
OIIO master recently added the ability to auto-build OCIO when a new enough one is not found at its build time, and bumped the minimum OCIO to 2.2.
Sometimes this is triggered by OSL's CI, when OCIO < 2.2, so building OIIO also triggers building of OCIO.
All fine, except for the case when we are testing Intel's icx compiler, which OCIO's build system does not recognize and fails to build. So we make a little modification here that lets us, just for that case, ensure that OCIO is pre-built with gcc even though we're building OIIO and OSL with icx.