build(deps): Raise minimum CMake dependency from 3.12 to 3.15 (#1724)

This bump brings access to the following interesting features (not a comprehensive list): - 3.13 Nov 21, 2018 - -B, -S let you specify source and build directories without the "cd" dance - target_link_options() - ctest --progress / CTEST_PROGRESS_OUTPUT - 3.14 Mar 14, 2019 - cmake --build now supports -v/--verbose - file(CREATE_LINK ) - 3.15 Jul 17, 2019 - env CMAKE_GENERATOR can be used instead of -G - when using --build, the --target can now list multiple targets (and also can be `-t`) - --install can be used separately without running through the whole build - message() now supports NOTICE, VERBOSE, DEBUG and TRACE. - CMAKE_FIND_PACKAGE_PREFER_CONFIG variable - Enable C++20 for Apple Clang Make sure all CI cases have a new enough cmake Use message(VERBOSE ...) feature to simplify lots of `if` blocks. Clean up code for older cmake versions Freshen some of our CI build_<dependency>.bash scripts. Note that this will NOT be backported to the current release branch, but it will be part of the upcoming 1.13 family of releases. Signed-off-by: Larry Gritz <[email protected]>
AcademySoftwareFoundation · Sep 15, 2023 · 46250b4 · 46250b4
1 parent e235661
commit 46250b4
Show file tree

Hide file tree

Showing 21 changed files with 90 additions and 132 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -45,6 +45,7 @@ jobs:
             openimageio_ver: v2.4.13.0
             python_ver: 2.7
             pybind11_ver: v2.4.2
+            setenvs: export CMAKE_VERSION=3.15.5
           - desc: clang9/C++14 llvm9 oiio-release boost1.66 avx2 exr2.3 py2.7
             nametag: linux-clang9-llvm9
             os: ubuntu-20.04
@@ -57,6 +58,7 @@ jobs:
             python_ver: 2.7
             # pybind11_ver: v2.9.0
             simd: avx
+            setenvs: export CMAKE_VERSION=3.15.5
           - desc: gcc6/C++14 llvm10 py3.7 boost1.70 exr2.4 oiio2.2 sse4
             nametag: linux-vfx2020
             os: ubuntu-latest
@@ -169,6 +171,7 @@ jobs:
             pybind11_ver: v2.6.2
             simd: 0
             setenvs: export PUGIXML_VERSION=v1.8
+                            CMAKE_VERSION=3.15.5
 
           # Address and leak sanitizers
           - desc: sanitizers

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -2,7 +2,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # https://github.com/AcademySoftwareFoundation/OpenShadingLanguage
 
-cmake_minimum_required (VERSION 3.12)
+cmake_minimum_required (VERSION 3.15)
 
 set (OSL_VERSION "1.13.5.0")
 set (OSL_VERSION_OVERRIDE "" CACHE STRING

diff --git a/INSTALL.md b/INSTALL.md
@@ -12,7 +12,7 @@ Dependencies
 OSL requires the following dependencies or tools.
 NEW or CHANGED dependencies since the last major release are **bold**.
 
-* Build system: [CMake](https://cmake.org/) 3.12 or newer (tested through 3.26)
+* Build system: [CMake](https://cmake.org/) **3.15 or newer** (tested through 3.27)
 
 * A suitable C++14 or C++17 compiler to build OSL itself, which may be any of:
    - GCC 6.1 or newer (tested through gcc 12.1)
@@ -92,9 +92,16 @@ Here are the steps to check out, build, and test the OSL distribution:
    options, and note that 'make nuke' will blow everything away for the
    freshest possible compile.
 
-   NOTE: If the build breaks due to compiler warnings which have been
-   elevated to errors, you can try "make clean" followed by
-   "make STOP_ON_WARNING=0", that create a build that will only stop for
+   You can also ignore the top level Makefile wrapper, and instead use
+   CMake directly:
+
+       cmake -B build -S .
+       cmake --build build --target install
+
+   NOTE: If the build breaks due to compiler warnings which have been elevated
+   to errors, you can try "make clean" followed by "make STOP_ON_WARNING=0",
+   or if using cmake directly, add `-DSTOP_ON_WARNING=0` to the cmake
+   configuration command. That will create a build that will only stop for
    full errors, not warnings.
 
 4. After compilation, you'll end up with a full OSL distribution in

diff --git a/src/build-scripts/build_cmake.bash b/src/build-scripts/build_cmake.bash
@@ -12,7 +12,7 @@ set -ex
 echo "Building cmake"
 uname
 
-CMAKE_VERSION=${CMAKE_VERSION:=3.12.4}
+CMAKE_VERSION=${CMAKE_VERSION:=3.18.5}
 LOCAL_DEPS_DIR=${LOCAL_DEPS_DIR:=${PWD}/ext}
 CMAKE_INSTALL_DIR=${CMAKE_INSTALL_DIR:=${LOCAL_DEPS_DIR}/cmake}
 

diff --git a/src/build-scripts/build_opencolorio.bash b/src/build-scripts/build_opencolorio.bash
@@ -11,13 +11,14 @@ set -ex
 
 # Which OCIO to retrieve, how to build it
 OPENCOLORIO_REPO=${OPENCOLORIO_REPO:=https://github.com/AcademySoftwareFoundation/OpenColorIO.git}
-OPENCOLORIO_VERSION=${OPENCOLORIO_VERSION:=v1.1.1}
+OPENCOLORIO_VERSION=${OPENCOLORIO_VERSION:=v2.2.1}
 
 # Where to install the final results
 LOCAL_DEPS_DIR=${LOCAL_DEPS_DIR:=${PWD}/ext}
 OPENCOLORIO_SOURCE_DIR=${OPENCOLORIO_SOURCE_DIR:=${LOCAL_DEPS_DIR}/OpenColorIO}
 OPENCOLORIO_BUILD_DIR=${OPENCOLORIO_BUILD_DIR:=${LOCAL_DEPS_DIR}/OpenColorIO-build}
 OPENCOLORIO_INSTALL_DIR=${OPENCOLORIO_INSTALL_DIR:=${LOCAL_DEPS_DIR}/dist}
+OPENCOLORIO_BUILD_TYPE=${OPENCOLORIO_BUILD_TYPE:=Release}
 OPENCOLORIO_CXX_FLAGS=${OPENCOLORIO_CXX_FLAGS:="-Wno-unused-function -Wno-deprecated-declarations -Wno-cast-qual -Wno-write-strings"}
 # Just need libs:
 OPENCOLORIO_BUILDOPTS="-DOCIO_BUILD_APPS=OFF -DOCIO_BUILD_NUKE=OFF \
@@ -42,13 +43,12 @@ cd ${OPENCOLORIO_SOURCE_DIR}
 
 echo "git checkout ${OPENCOLORIO_VERSION} --force"
 git checkout ${OPENCOLORIO_VERSION} --force
-mkdir -p ${OPENCOLORIO_BUILD_DIR}
-cd ${OPENCOLORIO_BUILD_DIR}
-time cmake -DCMAKE_BUILD_TYPE=Release \
+time cmake -S . -B ${OPENCOLORIO_BUILD_DIR} \
+           -DCMAKE_BUILD_TYPE=${OPENCOLORIO_BUILD_TYPE} \
            -DCMAKE_INSTALL_PREFIX=${OPENCOLORIO_INSTALL_DIR} \
            -DCMAKE_CXX_FLAGS="${OPENCOLORIO_CXX_FLAGS}" \
-           ${OPENCOLORIO_BUILDOPTS} ${OPENCOLORIO_SOURCE_DIR}
-time cmake --build . --config Release --target install
+           ${OPENCOLORIO_BUILDOPTS}
+time cmake --build ${OPENCOLORIO_BUILD_DIR} --config Release --target install
 popd
 
 # ls -R ${OPENCOLORIO_INSTALL_DIR}

diff --git a/src/build-scripts/build_openexr.bash b/src/build-scripts/build_openexr.bash
@@ -44,8 +44,8 @@ git checkout ${OPENEXR_VERSION} --force
 
 if [[ ${OPENEXR_VERSION} == "v2.3.0" ]] ; then
     # Simplified setup for 2.3+
-    cd ${OPENEXR_BUILD_DIR}
-    cmake -DCMAKE_BUILD_TYPE=${OPENEXR_BUILD_TYPE} \
+    cmake   -S . -B ${OPENEXR_BUILD_DIR} \
+            -DCMAKE_BUILD_TYPE=${OPENEXR_BUILD_TYPE} \
             -DCMAKE_INSTALL_PREFIX="${OPENEXR_INSTALL_DIR}" \
             -DCMAKE_PREFIX_PATH="${CMAKE_PREFIX_PATH}" \
             -DILMBASE_PACKAGE_PREFIX="${OPENEXR_INSTALL_DIR}" \
@@ -54,11 +54,11 @@ if [[ ${OPENEXR_VERSION} == "v2.3.0" ]] ; then
             -DOPENEXR_BUILD_PYTHON_LIBS=0 \
             -DCMAKE_CXX_FLAGS="${OPENEXR_CXX_FLAGS}" \
             ${OPENEXR_CMAKE_FLAGS} ${OPENEXR_SOURCE_DIR}
-    time cmake --build . --target install --config ${OPENEXR_BUILD_TYPE}
+    time cmake --build ${OPENEXR_BUILD_DIR} --target install --config ${OPENEXR_BUILD_TYPE}
 else
     # Simplified setup for 2.4+
-    cd ${OPENEXR_BUILD_DIR}
-    cmake -DCMAKE_BUILD_TYPE=${OPENEXR_BUILD_TYPE} \
+    cmake   -S . -B ${OPENEXR_BUILD_DIR} \
+            -DCMAKE_BUILD_TYPE=${OPENEXR_BUILD_TYPE} \
             -DCMAKE_INSTALL_PREFIX="${OPENEXR_INSTALL_DIR}" \
             -DCMAKE_PREFIX_PATH="${CMAKE_PREFIX_PATH}" \
             -DILMBASE_PACKAGE_PREFIX="${OPENEXR_INSTALL_DIR}" \
@@ -71,7 +71,7 @@ else
             -DCMAKE_INSTALL_LIBDIR=lib \
             -DCMAKE_CXX_FLAGS="${OPENEXR_CXX_FLAGS}" \
             ${OPENEXR_CMAKE_FLAGS} ${OPENEXR_SOURCE_DIR}
-    time cmake --build . --target install --config ${OPENEXR_BUILD_TYPE}
+    time cmake --build ${OPENEXR_BUILD_DIR} --target install --config ${OPENEXR_BUILD_TYPE}
 fi
 
 popd

diff --git a/src/build-scripts/build_pugixml.bash b/src/build-scripts/build_pugixml.bash
@@ -11,7 +11,7 @@ set -ex
 
 # Repo and branch/tag/commit of pugixml to download if we don't have it yet
 PUGIXML_REPO=${PUGIXML_REPO:=https://github.com/zeux/pugixml.git}
-PUGIXML_VERSION=${PUGIXML_VERSION:=v1.10}
+PUGIXML_VERSION=${PUGIXML_VERSION:=v1.11.4}
 
 # Where to put pugixml repo source (default to the ext area)
 PUGIXML_SRC_DIR=${PUGIXML_SRC_DIR:=${PWD}/ext/pugixml}
@@ -34,17 +34,18 @@ if [[ ! -e ${PUGIXML_SRC_DIR} ]] ; then
     git clone ${PUGIXML_REPO} ${PUGIXML_SRC_DIR}
 fi
 cd ${PUGIXML_SRC_DIR}
+
 echo "git checkout ${PUGIXML_VERSION} --force"
 git checkout ${PUGIXML_VERSION} --force
 
-mkdir -p ${PUGIXML_BUILD_DIR}
-cd ${PUGIXML_BUILD_DIR}
-time cmake -DCMAKE_BUILD_TYPE=Release \
-           -DCMAKE_INSTALL_PREFIX=${PUGIXML_INSTALL_DIR} \
-           -DBUILD_SHARED_LIBS=ON \
-           -DBUILD_TESTS=OFF \
-           ${PUGIXML_BUILD_OPTS} ..
-time cmake --build . --config Release --target install
+if [[ -z $DEP_DOWNLOAD_ONLY ]]; then
+    time cmake -S . -B ${PUGIXML_BUILD_DIR} -DCMAKE_BUILD_TYPE=Release \
+               -DCMAKE_INSTALL_PREFIX=${PUGIXML_INSTALL_DIR} \
+               -DBUILD_SHARED_LIBS=ON \
+               -DBUILD_TESTS=OFF \
+               ${PUGIXML_BUILD_OPTS} ..
+    time cmake --build ${PUGIXML_BUILD_DIR} --config Release --target install
+fi
 
 # ls -R ${PUGIXML_INSTALL_DIR}
 popd

diff --git a/src/build-scripts/build_pybind11.bash b/src/build-scripts/build_pybind11.bash
@@ -42,15 +42,12 @@ cd ${PYBIND11_SRC_DIR}
 echo "git checkout ${PYBIND11_VERSION} --force"
 git checkout ${PYBIND11_VERSION} --force
 
-mkdir -p ${PYBIND11_BUILD_DIR}
-cd ${PYBIND11_BUILD_DIR}
-
 if [[ -z $DEP_DOWNLOAD_ONLY ]]; then
-    time cmake -DCMAKE_BUILD_TYPE=Release \
+    time cmake -S . -B ${PYBIND11_BUILD_DIR} -DCMAKE_BUILD_TYPE=Release \
                -DCMAKE_INSTALL_PREFIX=${PYBIND11_INSTALL_DIR} \
                -DPYBIND11_TEST=OFF \
-               ${PYBIND11_BUILD_OPTS} ..
-    time cmake --build . --config Release --target install
+               ${PYBIND11_BUILD_OPTS}
+    time cmake --build ${PYBIND11_BUILD_DIR} --config Release --target install
 fi
 
 # ls -R ${PYBIND11_INSTALL_DIR}

diff --git a/src/build-scripts/gh-installdeps.bash b/src/build-scripts/gh-installdeps.bash
@@ -126,6 +126,10 @@ else
     source src/build-scripts/build_llvm.bash
 fi
 
+if [[ "$CMAKE_VERSION" != "" ]] ; then
+    source src/build-scripts/build_cmake.bash
+fi
+cmake --version
 
 
 if [[ "$OPTIX_VERSION" != "" ]] ; then
@@ -147,11 +151,10 @@ if [[ "$OPTIX_VERSION" != "" ]] ; then
 fi
 
 
-if [[ "$CMAKE_VERSION" != "" ]] ; then
-    source src/build-scripts/build_cmake.bash
-fi
-cmake --version
 
+#
+# Packages we need to build from scratch.
+#
 
 source src/build-scripts/build_pybind11.bash
 

diff --git a/src/cmake/compiler.cmake b/src/cmake/compiler.cmake
@@ -15,13 +15,11 @@
 ###########################################################################
 # Print some basic status about the system and compiler
 #
-if (VERBOSE)
-    message (STATUS "CMAKE_SYSTEM_NAME      = ${CMAKE_SYSTEM_NAME}")
-    message (STATUS "CMAKE_SYSTEM_VERSION   = ${CMAKE_SYSTEM_VERSION}")
-    message (STATUS "CMAKE_SYSTEM_PROCESSOR = ${CMAKE_SYSTEM_PROCESSOR}")
-endif ()
-message (STATUS "CMAKE_CXX_COMPILER     = ${CMAKE_CXX_COMPILER}")
-message (STATUS "CMAKE_CXX_COMPILER_ID  = ${CMAKE_CXX_COMPILER_ID}")
+message (VERBOSE "CMAKE_SYSTEM_NAME      = ${CMAKE_SYSTEM_NAME}")
+message (VERBOSE "CMAKE_SYSTEM_VERSION   = ${CMAKE_SYSTEM_VERSION}")
+message (VERBOSE "CMAKE_SYSTEM_PROCESSOR = ${CMAKE_SYSTEM_PROCESSOR}")
+message (STATUS  "CMAKE_CXX_COMPILER     = ${CMAKE_CXX_COMPILER}")
+message (STATUS  "CMAKE_CXX_COMPILER_ID  = ${CMAKE_CXX_COMPILER_ID}")
 
 
 ###########################################################################
@@ -44,9 +42,7 @@ if (CMAKE_COMPILER_IS_GNUCC)
     execute_process (COMMAND ${CMAKE_CXX_COMPILER} -dumpversion
                      OUTPUT_VARIABLE GCC_VERSION
                      OUTPUT_STRIP_TRAILING_WHITESPACE)
-    if (VERBOSE)
-        message (STATUS "Using gcc ${GCC_VERSION} as the compiler")
-    endif ()
+    message (VERBOSE "Using gcc ${GCC_VERSION} as the compiler")
 else ()
     set (GCC_VERSION 0)
 endif ()
@@ -63,26 +59,18 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR CMAKE_CXX_COMPILER MATCHES "[Cc]lan
         set (CMAKE_CXX_COMPILER_ID "AppleClang")
         set (CMAKE_COMPILER_IS_APPLECLANG 1)
         string (REGEX REPLACE ".* version ([0-9]+\\.[0-9]+).*" "\\1" APPLECLANG_VERSION_STRING ${clang_full_version_string})
-        if (VERBOSE)
-            message (STATUS "The compiler is Clang: ${CMAKE_CXX_COMPILER_ID} version ${APPLECLANG_VERSION_STRING}")
-        endif ()
+        message (VERBOSE "The compiler is Clang: ${CMAKE_CXX_COMPILER_ID} version ${APPLECLANG_VERSION_STRING}")
     elseif (CMAKE_CXX_COMPILER_ID MATCHES "IntelLLVM")
         set (CMAKE_COMPILER_IS_INTELCLANG 1)
         string (REGEX MATCH "[0-9]+(\\.[0-9]+)+" INTELCLANG_VERSION_STRING ${clang_full_version_string})
-        if (VERBOSE)
-            message (STATUS "The compiler is Intel Clang: ${CMAKE_CXX_COMPILER_ID} version ${INTELCLANG_VERSION_STRING}")
-        endif ()
+        message (VERBOSE "The compiler is Intel Clang: ${CMAKE_CXX_COMPILER_ID} version ${INTELCLANG_VERSION_STRING}")
     else ()
         string (REGEX REPLACE ".* version ([0-9]+\\.[0-9]+).*" "\\1" CLANG_VERSION_STRING ${clang_full_version_string})
-        if (VERBOSE)
-            message (STATUS "The compiler is Clang: ${CMAKE_CXX_COMPILER_ID} version ${CLANG_VERSION_STRING}")
-        endif ()
+        message (VERBOSE "The compiler is Clang: ${CMAKE_CXX_COMPILER_ID} version ${CLANG_VERSION_STRING}")
     endif ()
 elseif (CMAKE_CXX_COMPILER_ID MATCHES "Intel")
     set (CMAKE_COMPILER_IS_INTEL 1)
-    if (VERBOSE)
-        message (STATUS "Using Intel as the compiler")
-    endif ()
+    message (VERBOSE "Using Intel as the compiler")
 endif ()
 
 
@@ -314,9 +302,7 @@ if (NOT USE_SIMD STREQUAL "")
     else ()
         string (REPLACE "," ";" SIMD_FEATURE_LIST ${USE_SIMD})
         foreach (feature ${SIMD_FEATURE_LIST})
-            if (VERBOSE)
-                message (STATUS "SIMD feature: ${feature}")
-            endif ()
+            message (VERBOSE "SIMD feature: ${feature}")
             if (MSVC OR CMAKE_COMPILER_IS_INTEL)
                 set (SIMD_COMPILE_FLAGS ${SIMD_COMPILE_FLAGS} "/arch:${feature}")
             else ()
@@ -423,7 +409,7 @@ if (CLANG_TIDY)
     find_program(CLANG_TIDY_EXE NAMES "clang-tidy"
                  DOC "Path to clang-tidy executable")
     message (STATUS "CLANG_TIDY_EXE ${CLANG_TIDY_EXE}")
-    if (CLANG_TIDY_EXE AND NOT ${CMAKE_VERSION} VERSION_LESS 3.6)
+    if (CLANG_TIDY_EXE)
         set (CMAKE_CXX_CLANG_TIDY
              "${CLANG_TIDY_EXE}"
              )
@@ -525,9 +511,7 @@ else ()
     set (SOVERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}
          CACHE STRING "Set the SO version for dynamic libraries")
 endif ()
-if (VERBOSE)
-    message(STATUS "Setting SOVERSION to: ${SOVERSION}")
-endif ()
+message(VERBOSE "Setting SOVERSION to: ${SOVERSION}")
 
 
 ###########################################################################
@@ -589,9 +573,7 @@ else ()
     # add the automatically determined parts of the RPATH that
     # point to directories outside the build tree to the install RPATH
     set (CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)
-    if (VERBOSE)
-        message (STATUS "CMAKE_INSTALL_RPATH = ${CMAKE_INSTALL_RPATH}")
-    endif ()
+    message (VERBOSE "CMAKE_INSTALL_RPATH = ${CMAKE_INSTALL_RPATH}")
 endif ()
 # OSL considerations because we run oslc in the course of building:
 # Use (i.e. don't skip) the full RPATH for the build tree

diff --git a/src/cmake/cuda_macros.cmake b/src/cmake/cuda_macros.cmake
@@ -69,9 +69,7 @@ function ( MAKE_CUDA_BITCODE src suffix generated_bc extra_clang_args )
 
     # Setup the compile flags
     get_property (CURRENT_DEFINITIONS DIRECTORY PROPERTY COMPILE_DEFINITIONS)
-    if (VERBOSE)
-        message (STATUS "Current #defines are ${CURRENT_DEFINITIONS}")
-    endif ()
+    message (VERBOSE "Current #defines are ${CURRENT_DEFINITIONS}")
     foreach (def ${CURRENT_DEFINITIONS})
         set (LLVM_COMPILE_FLAGS ${LLVM_COMPILE_FLAGS} "-D${def}")
     endforeach()
@@ -90,9 +88,7 @@ function ( MAKE_CUDA_BITCODE src suffix generated_bc extra_clang_args )
     if (NOT LLVM_BC_GENERATOR)
         message (FATAL_ERROR "You must have a valid llvm bitcode generator (clang++) somewhere.")
     endif ()
-    if (VERBOSE)
-        message (STATUS "Using LLVM_BC_GENERATOR ${LLVM_BC_GENERATOR} to generate bitcode.")
-    endif()
+    message (VERBOSE "Using LLVM_BC_GENERATOR ${LLVM_BC_GENERATOR} to generate bitcode.")
 
     if (NOT LLVM_AS_TOOL)
       find_program (LLVM_AS_TOOL NAMES "llvm-as"

diff --git a/src/cmake/externalpackages.cmake b/src/cmake/externalpackages.cmake
@@ -53,7 +53,9 @@ else ()
     # cmake output (e.g. boost 1.70.0, cmake <= 3.14). Specifically it fails
     # to set the expected variables printed below. So until that's fixed
     # force FindBoost.cmake to use the original brute force path.
-    set (Boost_NO_BOOST_CMAKE ON)
+    if (NOT DEFINED Boost_NO_BOOST_CMAKE)
+        set (Boost_NO_BOOST_CMAKE ON)
+    endif ()
     checked_find_package (Boost REQUIRED
                        VERSION_MIN 1.55
                        COMPONENTS ${Boost_COMPONENTS}

diff --git a/src/cmake/flexbison.cmake b/src/cmake/flexbison.cmake
@@ -38,9 +38,7 @@ if ( FLEX_EXECUTABLE AND BISON_EXECUTABLE )
         # XXX: This may be excessive now that OSL::pvt::ExtraArg is mangled into the function signature
         add_definitions(-D${prefix}parse=${PROJ_NAMESPACE_V}_${prefix}parse)
 
-        if (VERBOSE)
-            message (STATUS "FLEX_BISON flex=${flexsrc} bison=${bisonsrc} prefix=${prefix}")
-        endif ()
+        message (VERBOSE "FLEX_BISON flex=${flexsrc} bison=${bisonsrc} prefix=${prefix}")
         get_filename_component ( bisonsrc_we ${bisonsrc} NAME_WE )
         set ( bisonoutputcxx "${CMAKE_CURRENT_BINARY_DIR}/${bisonsrc_we}.cpp" )
         set ( bisonoutputh "${CMAKE_CURRENT_BINARY_DIR}/${bisonsrc_we}.h" )
@@ -54,9 +52,7 @@ if ( FLEX_EXECUTABLE AND BISON_EXECUTABLE )
         get_filename_component ( FLEX_UP ${FLEX_EXECUTABLE} PATH )
         get_filename_component ( FLEX_UP_UP ${FLEX_UP} PATH )
         set ( FLEX_INCLUDE_DIR "${FLEX_UP_UP}/include" )
-        if (VERBOSE)
-            message (STATUS "Flex include dir = ${FLEX_INCLUDE_DIR}")
-        endif ()
+        message (VERBOSE "Flex include dir = ${FLEX_INCLUDE_DIR}")
         include_directories ( ${FLEX_INCLUDE_DIR} )
 
         # include_directories ( ${CMAKE_CURRENT_BINARY_DIR} )