Finish removing Imath include

[ThiagoIze]

lgritz@4cb956b lost this removal when resolving a merge conflict. This properly removes it.

Signed-off-by: Thiago Ize

Description

#4076 implemented matrix44::inverse() so that we could stop including Imath.h. It removed the Imath.h include in the master/dev-2.6 branch but the dev-2.5 branch kept the include, likely because of an improperly resolved merge conflict. This PR removes the include like in master.

Tests

No tests are needed. As long as it compiles, this should be good. I verified this builds on arm64.

Checklist:

• I have read the contribution guidelines.
• I have updated the documentation, if applicable.
• I have ensured that the change is tested somewhere in the testsuite
  (adding new test cases if necessary).
• If I added or modified a C++ API call, I have also amended the
  corresponding Python bindings (and if altering ImageBufAlgo functions, also
  exposed the new functionality as oiiotool options).
• My code follows the prevailing code style of this project. If I haven't
  already run clang-format before submitting, I definitely will look at the CI
  test that runs clang-format and fix anything that it highlights as being
  nonconforming.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: ThiagoIze / name: Thiago Ize (3c9ed7b)

[lgritz]

@ThiagoIze Can you please add the DCO to the commit and make sure it uses the email under which you have your CLA registered? Should look like this:

$ git commit --amend -s --author="Thiago Ize <correct email>"
$ git push origin Imath-include --force

Don't mind the MacOS failure, that's something unrelated that we're seeing on 2.5 generally (but not master, interestingly). I haven't had a chance to track it down yet.

[ThiagoIze]

Don't mind the MacOS failure, that's something unrelated that we're seeing on 2.5 generally (but not master, interestingly). I haven't had a chance to track it down yet.

I haven't tried it, but I bet if you backported 68666db it would fix the unit test fail. Specifically this change:

-    OIIO_CHECK_SIMD_EQUAL (fast_exp(A),
-                mkvec<VEC>(fast_exp(A[0]), fast_exp(A[1]), fast_exp(A[2]), fast_exp(A[3])));
+   OIIO_CHECK_SIMD_EQUAL_THRESH (fast_exp(A),
+                mkvec<VEC>(fast_exp(A[0]), fast_exp(A[1]), fast_exp(A[2]), fast_exp(A[3])), 1e-5f);

[lgritz]

I will try backporting those lines and see if it addreses the problem.