build: suppress Xcode warnings #3940
Conversation
Signed-off-by: Anton Dukhovnikov <[email protected]>
When building the code with Xcode ("cmake -G Xcode"), there are 1000+
warnings about implicit 64 to 32 bit conversion.
This change adds a compile option to suppress such warnings when
generating an Xcode project.
Signed-off-by: Anton Dukhovnikov <[email protected]>
|
I know I already approved and merged this, but... Do you have any explanation for why this only was a warning for xcode, and not any of the other compilers (including clang on Apple, when not having CMake generate xcode project files)? |
|
That particular warning is enabled by default in Xcode ("Implicit Conversion to 32 Bit Type" in Xcode project settings), so it has to be explicitly disabled in the project file. |
|
Are we confident that it's not a warning we should be addressing -- i.e., disabling the warning could lead to bugs and we should really aim to be fixing the places where the warning occurs? |
That would be good. Actually, I might just give it a go and try fixing as many as I can. |
|
I guess the question is -- are there really thousands of separate places that are just too painful to fix? Or is it in a header and fixing it there will simultaneously fix a whole lot of the warnings? |
Description
When building the code with Xcode ("cmake -G Xcode"), there are 1000+ warnings about implicit 64 to 32 bit conversion.
This change adds a compile option to suppress such warnings when generating an Xcode project.
Tests
None required
Checklist:
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
(adding new test cases if necessary).