Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant instructions from tile hash #3898

Merged
merged 7 commits into from
Jul 25, 2023
Merged

Remove redundant instructions from tile hash #3898

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
faaf216
Remove redundant instructions from hash
curtisblack Jun 26, 2023
98f4198
Ignore false warning about uninitialized tile data.
curtisblack Jul 21, 2023
e439abb
Remove redundant instructions from hash
curtisblack Jun 26, 2023
b9a57e0
Ignore false warning about uninitialized tile data.
curtisblack Jul 21, 2023
800bec7
Merge branch 'optimize_tile_hash' of https://github.com/curtisblack/o…
curtisblack Jul 23, 2023
36ec5b3
Move compiler ignore directives.
curtisblack Jul 24, 2023
789406c
Fix false positive warning about uninitialized memory in gcc11
lgritz Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/libtexture/imagecache_pvt.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,12 @@ struct TileID {
static_assert(
sizeof(*this) % sizeof(uint64_t) == 0,
"FastHash uses the fewest instructions when data size is a multiple of 8 bytes.");
// This appears to be a false positive which only affects GCC.
// https://godbolt.org/z/5q7Y7ndfb
OIIO_PRAGMA_WARNING_PUSH
OIIO_GCC_ONLY_PRAGMA(GCC diagnostic ignored "-Wuninitialized")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still failing. Based on the error message, I think this might need to be -Wmaybe-uninitialized?

return fasthash::fasthash64(this, sizeof(*this));
OIIO_PRAGMA_WARNING_POP
}

/// Functor that hashes a TileID
Expand Down
Loading