Skip to content

Commit

Permalink
deps(PNG): Always _only_ build shared libs
Browse files Browse the repository at this point in the history
Trying to get to the bottom of why OIIO is continuing to link system shared system PNG (CI images) instead of freshly-built static libs. Presumably, if I build shared PNG libs, OIIO will prefer the newer ones over the system libraries.
(Which I guess would mean any found dynamic libraries are preferred over any found static libraries...)

Signed-off-by: Zach Lewis <[email protected]>
  • Loading branch information
zachlewis committed Sep 16, 2024
1 parent 3cbb73d commit c56be56
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/cmake/build_PNG.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ set_cache (PNG_BUILD_VERSION 1.6.43 "PNG version for local builds")
set (PNG_GIT_REPOSITORY "https://github.com/glennrp/libpng")
set (PNG_GIT_TAG "v${PNG_BUILD_VERSION}")

set_cache (PNG_BUILD_SHARED_LIBS OFF #${LOCAL_BUILD_SHARED_LIBS_DEFAULT}
set_cache (PNG_BUILD_SHARED_LIBS ON #${LOCAL_BUILD_SHARED_LIBS_DEFAULT}
DOC "Should execute a local PNG build, if necessary, build shared libraries" ADVANCED)

string (MAKE_C_IDENTIFIER ${PNG_BUILD_VERSION} PNG_VERSION_IDENT)
Expand Down

0 comments on commit c56be56

Please sign in to comment.