-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UsdPreviewSurface Nodegraph #2081
Update UsdPreviewSurface Nodegraph #2081
Conversation
…oundation#2044. It also updates the nodegraph to reflect the recently updated PreviewSurface v2.5 which removes specular highlights for fully transparent materials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, @klucknav, and thanks for the updates!
5d6aa6e
into
AcademySoftwareFoundation:main
Do we need to retain the previous version as I think I recall @crydalch mentioning that he's seen people using I'm in favor of this change in the |
@ld-kerley Karen and I were just discussing this, but in my local testing, glass materials with zero opacity (i.e. maximum transmissive strength) render in the same fashion as before. That seems consistent with other industry shading models such as glTF PBR and Standard Surface, but if it's not the intent for UsdPreviewSurface, then additional updates may be needed. |
This changelist restores the interpretation of the reflective and transmissive specular terms of UsdPreviewSurface, reverting some unintended side effects of AcademySoftwareFoundation#2081.
This changelist restores the interpretation of the reflective and transmissive specular terms of UsdPreviewSurface, reverting some unintended aspects of PR AcademySoftwareFoundation#2081.
This changelist restores the interpretation of the reflective and transmissive specular terms of UsdPreviewSurface, reverting some unintended changes in PR AcademySoftwareFoundation#2081.
This changelist restores the interpretation of the reflective and transmissive specular terms of UsdPreviewSurface, reverting some unintended changes in PR #2081.
This PR fixes the cutout issue described in gitIssue #2044. It also updates the nodegraph to reflect the recently updated PreviewSurface v2.6 which removes specular highlights for fully transparent materials.