Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UsdPreviewSurface Nodegraph #2081

Conversation

klucknav
Copy link
Contributor

This PR fixes the cutout issue described in gitIssue #2044. It also updates the nodegraph to reflect the recently updated PreviewSurface v2.6 which removes specular highlights for fully transparent materials.

…oundation#2044. It also updates the nodegraph to reflect the recently updated PreviewSurface v2.5 which removes specular highlights for fully transparent materials.
Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, @klucknav, and thanks for the updates!

@jstone-lucasfilm jstone-lucasfilm changed the title Update Usd Preview Surface Nodegraph Update UsdPreviewSurface Nodegraph Oct 21, 2024
@jstone-lucasfilm jstone-lucasfilm merged commit 5d6aa6e into AcademySoftwareFoundation:main Oct 21, 2024
34 checks passed
@ld-kerley
Copy link
Contributor

Do we need to retain the previous version as version=2.3 and add this as a version=2.6?

I think I recall @crydalch mentioning that he's seen people using UsdPreviewSurface for rendering glass by setting opacity=0 and relying on the specular response remaining.

I'm in favor of this change in the UsdPreviewSurface spec, as it aligns its behavior with other shading models, but I wonder if MaterialX consumers might get caught out by the change, and retaining the older version would allow people to ensure an older look would still be achievable?

@jstone-lucasfilm
Copy link
Member

@ld-kerley Karen and I were just discussing this, but in my local testing, glass materials with zero opacity (i.e. maximum transmissive strength) render in the same fashion as before. That seems consistent with other industry shading models such as glTF PBR and Standard Surface, but if it's not the intent for UsdPreviewSurface, then additional updates may be needed.

jstone-lucasfilm added a commit to jstone-lucasfilm/MaterialX that referenced this pull request Oct 28, 2024
This changelist restores the interpretation of the reflective and transmissive specular terms of UsdPreviewSurface, reverting some unintended side effects of AcademySoftwareFoundation#2081.
jstone-lucasfilm added a commit to jstone-lucasfilm/MaterialX that referenced this pull request Oct 28, 2024
This changelist restores the interpretation of the reflective and transmissive specular terms of UsdPreviewSurface, reverting some unintended aspects of PR AcademySoftwareFoundation#2081.
jstone-lucasfilm added a commit to jstone-lucasfilm/MaterialX that referenced this pull request Oct 28, 2024
This changelist restores the interpretation of the reflective and transmissive specular terms of UsdPreviewSurface, reverting some unintended changes in PR AcademySoftwareFoundation#2081.
jstone-lucasfilm added a commit that referenced this pull request Oct 29, 2024
This changelist restores the interpretation of the reflective and transmissive specular terms of UsdPreviewSurface, reverting some unintended changes in PR #2081.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants