Add Python bindings for generation and rendering #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwokcb
commented
Jun 22, 2023
| @@ -0,0 +1,18 @@ | |||
| // | |||
There was a problem hiding this comment.
GLTF loader was missing so can't load a number of sample geometry.
| @@ -43,6 +43,9 @@ void bindPyDefinition(py::module& mod) | |||
| .def("getFunction", &mx::Implementation::getFunction) | |||
| .def("setNodeDef", &mx::Implementation::setNodeDef) | |||
| .def("getNodeDef", &mx::Implementation::getNodeDef) | |||
| .def("setNodeGraph", &mx::Implementation::setNodeGraph) | |||
There was a problem hiding this comment.
This is actually for definition creation but added in to avoid another PR.
| @@ -27,12 +27,18 @@ void bindPyGenOptions(py::module& mod) | |||
| .def_readwrite("shaderInterfaceType", &mx::GenOptions::shaderInterfaceType) | |||
| .def_readwrite("fileTextureVerticalFlip", &mx::GenOptions::fileTextureVerticalFlip) | |||
| .def_readwrite("targetColorSpaceOverride", &mx::GenOptions::targetColorSpaceOverride) | |||
| .def_readwrite("addUpstreamDependencies", &mx::GenOptions::addUpstreamDependencies) | |||
There was a problem hiding this comment.
This is required to be able to generate reference code for nodes.
jstone-lucasfilm
approved these changes
Jun 22, 2023
jstone-lucasfilm
changed the title
jstone-lucasfilm
changed the title
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
…dation#1386) Most of these wrapper updates are related to exposing missing APIs in Python for code gen and rendering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these wrapper updates are related to exposing missing APIs in Python for code gen and rendering.
For now this is for GLSL rendering in Python this is sufficient (driver is this example)