Merge pull request #34 from InvArch:yaki-sub-rerender-fix

Refactor useEffect dependencies to stop re-renders
Abstracted-Labs · Jan 9, 2024 · d46879c · d46879c
2 parents 7a4c6bd + 20b073d
commit d46879c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/routes/overview.tsx b/src/routes/overview.tsx
@@ -277,7 +277,8 @@ const Overview = () => {
         }
       });
     };
-  }, [setupSubscriptions, selectedAccount, api]);
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [selectedAccount, api]);
 
   return (
     <div className="mx-auto w-full flex max-w-7xl flex-col justify-between p-4 sm:px-6 lg:px-8 mt-14 md:mt-0 gap-3">

diff --git a/src/routes/staking.tsx b/src/routes/staking.tsx
@@ -550,13 +550,15 @@ const Staking = () => {
         if (unsub) {
           unsub.then(unsubFunc => {
             if (typeof unsubFunc === 'function') {
+              console.log("Unsubscribing from subscription");
               unsubFunc();
             }
           });
         }
       });
     };
-  }, [selectedAccount, setupSubscriptions, api]);
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [selectedAccount, api]);
 
   return (
     <div className="mx-auto w-full flex max-w-7xl flex-col justify-between p-4 sm:px-6 lg:px-8 mt-14 md:mt-0 gap-3">