-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: automatic release management #33
Conversation
4e118a8
to
7f38cdf
Compare
Marking as draft again. There is still an issue with the workflow failing because it expects tags and then not creating a release PR. |
06445fc
to
c617d1b
Compare
I had to revert back to giving each crate its own version, because See also: googleapis/release-please#2111 Here's an example of what a release PR looks like: mrcjkb#3 It currently updates the changelog in each crate, but I think we can live with that until |
c617d1b
to
28ba6b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Anything left to do before merging?
Btw. for the future, we could consider adding automatic crates.io releases.
I think it's good to merge now. crates.io releases sounds like a good idea too 😃 |
Thanks! |
Closes #30
Will create release PRs, bumping the version and adding changelog entries, based on conventional commits.
Currently, conventional commits are not enforced. I haven't yet found a way to do so in a way that works nicely with the
release-please
workflow.If people contribute with non-conventional commits, you can make the PR title CC compliant, and squash merge.