Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: automatic release management #33

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

mrcjkb
Copy link
Contributor

@mrcjkb mrcjkb commented Oct 31, 2023

Closes #30

Will create release PRs, bumping the version and adding changelog entries, based on conventional commits.

Currently, conventional commits are not enforced. I haven't yet found a way to do so in a way that works nicely with the release-please workflow.
If people contribute with non-conventional commits, you can make the PR title CC compliant, and squash merge.

  • You may also need to set "Allow GitHub Actions to create and approve pull requests" under repository Settings > Actions > General.

@mrcjkb mrcjkb marked this pull request as draft October 31, 2023 22:18
@mrcjkb mrcjkb marked this pull request as ready for review October 31, 2023 23:01
@mrcjkb
Copy link
Contributor Author

mrcjkb commented Nov 1, 2023

Marking as draft again. There is still an issue with the workflow failing because it expects tags and then not creating a release PR.

@mrcjkb mrcjkb marked this pull request as draft November 1, 2023 00:59
@mrcjkb mrcjkb force-pushed the release-automation branch 2 times, most recently from 06445fc to c617d1b Compare November 2, 2023 16:57
@mrcjkb
Copy link
Contributor Author

mrcjkb commented Nov 2, 2023

I had to revert back to giving each crate its own version, because release-please doesn't seem to support workspace.version.

See also: googleapis/release-please#2111

Here's an example of what a release PR looks like: mrcjkb#3

It currently updates the changelog in each crate, but I think we can live with that until release-please supports workspace.version.

@mrcjkb mrcjkb marked this pull request as ready for review November 2, 2023 16:58
Copy link
Owner

@AaronErhardt AaronErhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Anything left to do before merging?

Btw. for the future, we could consider adding automatic crates.io releases.

@mrcjkb
Copy link
Contributor Author

mrcjkb commented Nov 2, 2023

Looks good. Anything left to do before merging?

Btw. for the future, we could consider adding automatic crates.io releases.

I think it's good to merge now.
Might need some refinement, but I can do that in a follow-up.

crates.io releases sounds like a good idea too 😃

@AaronErhardt AaronErhardt merged commit cbd8809 into AaronErhardt:main Nov 2, 2023
4 checks passed
@AaronErhardt
Copy link
Owner

Thanks!

@mrcjkb mrcjkb deleted the release-automation branch November 2, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate version bumps/release tags
2 participants