fix appointment bugs #166
Merged
fix appointment bugs #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
============================================
+ Coverage 66.70% 67.08% +0.37%
- Complexity 679 698 +19
============================================
Files 116 116
Lines 2658 2716 +58
Branches 288 309 +21
============================================
+ Hits 1773 1822 +49
+ Misses 790 787 -3
- Partials 95 107 +12
|
simbayippy
added
type.bug
tohpinren
requested changes
Nov 7, 2023
| .append(appointment.getDescription()) | ||
| .append("\n") | ||
| .append("Date: ") | ||
| .append(" | Date: ") | ||
| .append(appointment.getDateTime()); |
There was a problem hiding this comment.
Can you change this appointment datetime string to "01 Jan 2024 09.00AM" format?
There was a problem hiding this comment.
sure! just added
tohpinren
approved these changes
Nov 8, 2023
|
LGTM previous issues were fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains fixes for 7 main things
A:
Appointment message for add, delete, edit Appointments now shows the appropriate message upon success
B:
edit_appointment command now fixed to check for appropriate cases of:
C:
updated doctor's appointment list to contain edited appointment after calling edit_appt command. used to cause major bug that breaks application when the following commands are done in sequence
D:
fixed issue when editing a person's name does not change the appointments name
E:
fixed issue where after editing a person, his appointment details are lost in db.
F:
updated add appointment command to only accept timings between 9am to 5pm.
G:
changed appointments such that each timeslot can only have 1 appointment. i.e. 2 different doctors cannot have appointments on the same timeslot
Issues fixed and closed:
#125 #126 #128 #131 #133 #136 #139 #147 #149 #151 #153 #154 #156 #159 #163 #164