forked from nus-cs2103-AY2324S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalise UG for v1.3 #98
Merged
butteredyakiimo
merged 9 commits into
AY2324S1-CS2103T-T13-4:master
from
nananakx-x:branch-v1.3-final-ug
Nov 2, 2023
Merged
Finalise UG for v1.3 #98
butteredyakiimo
merged 9 commits into
AY2324S1-CS2103T-T13-4:master
from
nananakx-x:branch-v1.3-final-ug
Nov 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
=========================================
Coverage 61.56% 61.56%
Complexity 700 700
=========================================
Files 104 104
Lines 2867 2867
Branches 317 317
=========================================
Hits 1765 1765
Misses 1014 1014
Partials 88 88 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! minor changes
butteredyakiimo
approved these changes
Nov 2, 2023
butteredyakiimo
merged commit Nov 2, 2023
566d12a
into
AY2324S1-CS2103T-T13-4:master
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.