Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests and check code quality #145

Conversation

butteredyakiimo
Copy link
Collaborator

@butteredyakiimo butteredyakiimo commented Nov 10, 2023

  • created a method to check if a person is an available fosterer and whether a person is a current fosterer in person class
  • made a modification to the statsavail self invocation diagram

Note: codecov is failing because i modified the person class. What i added are already covered!!

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b426619) 63.23% compared to head (69dbd86) 63.40%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #145      +/-   ##
============================================
+ Coverage     63.23%   63.40%   +0.17%     
- Complexity      730      733       +3     
============================================
  Files           104      104              
  Lines          2927     2927              
  Branches        330      329       -1     
============================================
+ Hits           1851     1856       +5     
+ Misses          997      993       -4     
+ Partials         79       78       -1     
Files Coverage Δ
...eedu/address/logic/commands/StatsAvailCommand.java 100.00% <100.00%> (ø)
...ava/seedu/address/logic/commands/StatsCommand.java 20.00% <ø> (ø)
...du/address/logic/commands/StatsCurrentCommand.java 100.00% <100.00%> (+2.38%) ⬆️
...du/address/logic/commands/StatsHousingCommand.java 100.00% <100.00%> (ø)
...java/seedu/address/commons/core/index/Indices.java 94.00% <0.00%> (ø)
...c/main/java/seedu/address/model/person/Person.java 95.87% <66.66%> (+4.66%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@butteredyakiimo butteredyakiimo marked this pull request as draft November 10, 2023 11:31
@butteredyakiimo butteredyakiimo requested review from H1410101 and nananakx-x and removed request for H1410101 November 10, 2023 13:34
@butteredyakiimo butteredyakiimo marked this pull request as ready for review November 10, 2023 13:35
Copy link

@nananakx-x nananakx-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I will look at the tests in detail when I am adding on :P

@butteredyakiimo butteredyakiimo added this to the v1.4 milestone Nov 10, 2023
@butteredyakiimo butteredyakiimo merged commit e727083 into AY2324S1-CS2103T-T13-4:master Nov 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants