-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tests and check code quality #145
Add more tests and check code quality #145
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
============================================
+ Coverage 63.23% 63.40% +0.17%
- Complexity 730 733 +3
============================================
Files 104 104
Lines 2927 2927
Branches 330 329 -1
============================================
+ Hits 1851 1856 +5
+ Misses 997 993 -4
+ Partials 79 78 -1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I will look at the tests in detail when I am adding on :P
e727083
into
AY2324S1-CS2103T-T13-4:master
Note: codecov is failing because i modified the person class. What i added are already covered!!