Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UG and DG with Delete and Stats features, Fix some PED Documentation Bugs #139

Merged
merged 13 commits into from
Nov 8, 2023

Conversation

butteredyakiimo
Copy link
Collaborator

  • Make some PED bug fixes (see pic in tele)
  • Standardise notations used in UG
  • Add some planned enhancements
  • Edit use cases and user stories
  • Modify manual testing in DG
  • Add in implementation details for Delete and Stats

@butteredyakiimo butteredyakiimo added the documentation Improvements or additions to documentation label Nov 8, 2023
@butteredyakiimo butteredyakiimo added this to the v1.4 milestone Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe0efc1) 61.69% compared to head (31d2129) 61.69%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #139   +/-   ##
=========================================
  Coverage     61.69%   61.69%           
  Complexity      703      703           
=========================================
  Files           104      104           
  Lines          2872     2872           
  Branches        318      318           
=========================================
  Hits           1772     1772           
  Misses         1012     1012           
  Partials         88       88           
Files Coverage Δ
...java/seedu/address/commons/core/index/Indices.java 94.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@nananakx-x nananakx-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not really read the UG changes in detail, but will definitely do so when I am adding on later! We should merge this and later check if we still have formatting errors and I can change them later :)

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
@butteredyakiimo butteredyakiimo changed the title Branch docs Update UG and DG with Delete and Stats features, Fix some PED Documentation Bugs Nov 8, 2023
Copy link

@nananakx-x nananakx-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nananakx-x nananakx-x merged commit 20f42c0 into AY2324S1-CS2103T-T13-4:master Nov 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants