Merge pull request #174 from H1410101/fix-find-seq-diagrams

Add info note about lifelines and crosses in puml, edit seq diagram

docs/DeveloperGuide.md

@@ -481,6 +481,9 @@ Step 6. The `list` command stops here, and execution is returned to the `LogicMa
 
 The following diagram ignores details for `SearchPredicate`, which will be covered shortly:
 
+<div markdown="span" class="alert alert-info">:information_source: **Note:** Lifelines in the following sequence diagrams should end at the destroy marker (X) but due to a limitation of PlantUML, the lifeline reaches the end of diagram.
+</div>
+
 ![FindCommandSequenceDiagram.png](images/FindCommandSequenceDiagram.png)
 
 

docs/diagrams/FindCommandSequenceDiagram.puml

@@ -8,7 +8,7 @@ Participant ":LogicManager" as lm LOGIC_COLOR
 Participant ":AddressBookParser" as abp LOGIC_COLOR_T2
 Participant ":FindCommandParser" as fcp LOGIC_COLOR_T3
 Participant ":FindCommandArgumentParser" as argp LOGIC_COLOR_T4
-Participant ":FindCommand" as cmd MODEL_COLOR
+Participant "cmd:FindCommand" as cmd MODEL_COLOR
 Participant ":Model" as model STORAGE_COLOR
 
 user -[USER_COLOR]> mw : "list Tom/Sam"
@@ -40,12 +40,12 @@ destroy argp
 create cmd
 fcp -[LOGIC_COLOR_T3]> cmd
 
-fcp --[LOGIC_COLOR_T3]-> abp : FindCommand
+fcp --[LOGIC_COLOR_T3]-> abp : cmd
 deactivate fcp LOGIC_COLOR_T3
 fcp -[hidden]-> abp
 destroy fcp
 
-abp --[LOGIC_COLOR_T2]-> lm : FindCommand
+abp --[LOGIC_COLOR_T2]-> lm : cmd
 deactivate abp LOGIC_COLOR_T2
 
 lm -[LOGIC_COLOR]> cmd : execute(Model)