Update DG #341
Merged
Update DG #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
============================================
+ Coverage 77.38% 77.70% +0.31%
- Complexity 708 713 +5
============================================
Files 103 103
Lines 2198 2202 +4
Branches 224 224
============================================
+ Hits 1701 1711 +10
+ Misses 442 439 -3
+ Partials 55 52 -3 ☔ View full report in Codecov by Sentry. |
AlyssaPng
reviewed
Nov 14, 2023
Comment on lines
+56
to
78
|
|
||
| /** | ||
| * Creates a GatherCommand object for Financial Plan from {@code argString} | ||
| */ | ||
| private GatherCommand createGatherByFinancialPlan(String argString) throws ParseException { | ||
| String financialPlanArg = removePrefix(argString, PREFIX_FINANCIAL_PLAN); | ||
| validateFinancialPlan(financialPlanArg); | ||
| assert isValidFinancialPlanName(financialPlanArg) : "Prompt has to meets valid FP requirements"; | ||
| GatherEmailByFinancialPlan prompt = new GatherEmailByFinancialPlan(financialPlanArg); | ||
| return new GatherCommand(prompt); | ||
| } | ||
|
|
||
| /** | ||
| * Creates a GatherCommand object for Tag from {@code argString} | ||
| */ | ||
| private GatherCommand createGatherByTag(String argString) throws ParseException { | ||
| String tagArg = removePrefix(argString, PREFIX_TAG); | ||
| validateTag(tagArg); | ||
| assert isValidTagName(tagArg) : "Prompt has to meets valid Tag requirements"; | ||
| GatherEmailByTag prompt = new GatherEmailByTag(tagArg); | ||
| return new GatherCommand(prompt); | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.