Fixing xpath-filter pageUrlFilterRegex #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 29, 2013 12:58
Changing the regex filter xml attribute name from urlFilterRegex to pageUrlFilterRegex to match the documentation.
Fixing xpath-filter pageUrlFilterRegex
In the initial implementation, you could not have a property field with the same name as another property field in a different property list. It would incorrectly assume that the field should be put in twice. Adding an id to each property, and prepending each property field's name with the id separated by a delimiter allows for proper separation between the property lists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the regex filter xml attribute name from urlFilterRegex to
pageUrlFilterRegex to match the documentation.
Fixes #6