[Feat/#315] priority dropdown 취소 기능 구현 #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljh0608
changed the title
simeunseo
reviewed
Aug 20, 2024
github-actions
bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
changed the title
github-actions
bot
changed the title
ljh0608
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌀 해당 이슈 번호
🔹 어떤 것을 변경했나요?
🔹 어떻게 구현했나요?
드롭다운에 값이 채워졌을 때 x버튼을 렌더링 하도록 했고, 삭제 함수를 통해 해당 시간대의 priority값과 드롭다운의 선택된 값을 초기화
🔹 PR 포인트를 알려주세요!
PR이 늦은 이유.. 드롭다운 밖 영역을 클릭했을 때 닫히는 useOutSideClick 커스텀훅을 만들고 세개의 모달에 ref를 달아두어 사용하려고 했지만 map으로 동적 렌더링된 여러개의 컴포넌트에 ref를 붙이면 예상했던 것 과는 달리 마지막 컴포넌트에만 ref가 적용됩니다. 해당 이슈를 계속 알아보았지만, 잠시 스탑하고 해야될 일을 먼저 하겠습니다!
🔹 스크린샷을 남겨주세요!
2024-08-19.2.03.48.mov