Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMS: Increase timeout for send and get. Fix text SMS parsing when CRLF is contained in the text. #15477

Merged
merged 3 commits into from
Jun 8, 2024

Commits on Apr 5, 2024

  1. Increase AT timeout to 10s in AT_CellularSMS::send_sms

    For some devices sending can be slow (as an example see SIM800, it can be up to 60s), command is being run properly but default timeout is returning an invalid error.
    See https://www.elecrow.com/wiki/images/2/20/SIM800_Series_AT_Command_Manual_V1.09.pdf
    davidalo committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    5c49f16 View commit details
    Browse the repository at this point in the history
  2. Increase AT timeout to 10s in AT_CellularSMS::get_sms

    When SMS list is big and baudrate is not fast enough, with default timeout we can suffer from timeout error while getting a sms because method is parsing the full list and this takes long.
    davidalo committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    d676084 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2024

  1. Fix AT_CellularSMS::list_messages breaking in text mode when CRLF is …

    …contained in SMS payload text
    
    When parsing SMS, it can happen that we receive CRLF in the SMS payload (happened to me when receiving provider texts).
    As an example, we can receive:
    
    """
    Hello <CR><LF>
    World!
    """
    
    With previous implementation, second consume_to_stop_tag was stopping in <CR><LF> and rest of the code was failing for obvious reasons.
    With this commit we consume the full payload as bytes.
    davidalo committed May 11, 2024
    Configuration menu
    Copy the full SHA
    9e7e22d View commit details
    Browse the repository at this point in the history