Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MAX32660, MAX32670 SPI glitch fix #15453

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Fix MAX32660, MAX32670 SPI glitch fix #15453

merged 1 commit into from
Sep 13, 2023

Conversation

ozersa
Copy link
Contributor

@ozersa ozersa commented Sep 7, 2023 •
edited
Loading

Summary of changes

Do not disable SPI for manual drive mode during transaction setup
It has been reported that disabling SPI module causes glitch for manual SS drive mode

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ozersa
Fix: Do not disable SPI for manual drive mode during transaction setup
cbe0f73 
It has been reported that disabling SPI module causes glitch for manual SS drive mode

Signed-off-by: Sadik.Ozer <[email protected]>
@0xc0170 0xc0170 added needs: CI release-type: patch Indentifies a PR as containing just a patch labels Sep 8, 2023
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 8, 2023

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Sep 8, 2023
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 13, 2023

I restarted the tests, internal error

@mergify mergify bot added needs: CI and removed needs: work labels Sep 13, 2023
@mbed-ci
Copy link

mbed-ci commented Sep 13, 2023

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 7049bfc into ARMmbed:master Sep 13, 2023
11 checks passed
@mergify mergify bot removed the ready for merge label Sep 13, 2023
@multiplemonomials multiplemonomials mentioned this pull request Sep 24, 2023
Merged
felser added a commit to MultiTechSystems/mbed that referenced this pull request Oct 4, 2023
@felser
Fix SPI glitch on MAX32670
a322c3f 
Prevented SPI from working.
A fix for both the 32660 and 32660 was pushed by Maxim (ARMmbed#15453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-type: patch Indentifies a PR as containing just a patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ozersa @0xc0170 @mbed-ci