STM Sleep change dependency func from static to WEAK #15448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
change
static
toWEAK
for:ForcePeriphOutofDeepSleep
ForceOscOutofDeepSleep
wait_loop
Impact of changes
Migration actions required
Documentation
Since
deep_sleep
is declared asWEAK
(perfect), I needed on STM32 to create my owndeep_sleep
because I need sleep to be STOP1 and not STOP2 (I'm using LPTIM2 in counter mode but that's another story)But as
deep_sleep
callsForcePeriphOutofDeepSleep
,ForceOscOutofDeepSleep
andwait_loop
and as they are declaredstatic
they are unreachable from my code from link stage.So I needed to duplicate them into my code (not my favorite) to get it working.
But best is to remove
static
so I can call them from my owndeep_sleep
(and put them also as WEAK to be consistent) without need to duplicate code. Also this will avoid to check for any changes on original code to replicate it on my own.Pull request type
Test results
Reviewers
@jeromecoutant @0xc0170