Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nullpointer check in LWIP::socket_close #15435

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

chrJost
Copy link
Contributor

@chrJost chrJost commented Jul 5, 2023

Summary of changes

Add a nullpointer check for the structure which contains the TCP connection state.

We found that LWIP deletes a structure which contains the current TCP connection state. When calling close() on the corresponding socket the connection state is read, which results in a nullpointer access and subsequent crash.

Impact of changes

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

As far as we are aware no test covers this case.

Reviewers


@0xc0170
Copy link
Contributor

0xc0170 commented Jul 11, 2023

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 11, 2023

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jul 11, 2023
@0xc0170 0xc0170 merged commit 13f43cc into ARMmbed:master Jul 11, 2023
@mergify mergify bot removed the ready for merge label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-type: patch Indentifies a PR as containing just a patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants