add nullpointer check in LWIP::socket_close #15435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add a nullpointer check for the structure which contains the TCP connection state.
We found that LWIP deletes a structure which contains the current TCP connection state. When calling close() on the corresponding socket the connection state is read, which results in a nullpointer access and subsequent crash.
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
As far as we are aware no test covers this case.
Reviewers