Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMSIS pack update 2019-10-18 #11707

Conversation

JanneKiiskila
Copy link
Contributor

@JanneKiiskila JanneKiiskila commented Oct 18, 2019

Description

Updating of all CMSIS packs that running

python project.py --update-packs

brings, while using a customer version of cmsis-pack-manager.
(Essentially using the reqwest version from @theotherjimmy with
the TLS fix mentioned in the comments).

See:

for more details.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@adbridge @0xc0170 @theotherjimmy @ARMmbed/team-st-mcd

Release Notes

All CMSIS packs updated to status on 18th of October, 2019.

Updating of all CMSIS packs that running

```
python project.py -m STM32F7xx --update-packs
```

brings, while using a customer version of cmsis-pack-manager.
(Essentially using the reqwest version from theOtherJimmy with
the TLS fix mentioned in the comments).

See:

- pyocd/cmsis-pack-manager#121
- pyocd/cmsis-pack-manager#124

for more details.
@JanneKiiskila
Copy link
Contributor Author

Removed note on the -m , that doesn't really have any impact on the job the script does. It updates all.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 18, 2019

@JanneKiiskila Looks like there are errors in the updated packs, Travis found at least 3

@JanneKiiskila
Copy link
Contributor Author

JanneKiiskila commented Oct 18, 2019

Issue 1)

  • Seems the CC3220 is missing completely, I wonder why that is not coming up from the CMSIS-pack manager at all.
  • That can be added manually (but, the process fails - why?).

Issue 2)

  • AssertionError: Device name STM32F207ZG is misssing sector information
  • These are not coming in the same way for some reason, I wonder if the actual source CMSIS pack file has changed inbetween now?
  • New one says
        "name": "STM32F207ZGTx", 
        "processor": {
            "Symmetric": {
                "core": "CortexM3", 
                "fpu": "None", 
                "mpu": "Present", 
                "units": 1
            }
        }, 
        "sectors": null, 
    
  • So, indeed - there is no sector information!
  • Can be added manually, but why is it missing?

So, I found only two issues?

@theotherjimmy any insight on why these could happen?
@0xc0170 - how good is the test set, do we dare taking this in?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 18, 2019

  1. Good question, it could have been added manually? I can see it being added here https://github.com/ARMmbed/mbed-os/pull/11063/files#diff-5472a9e102e223699aaf5e10b3bd8d5c

We can add it manually to keep it as it was for now and investigate why it was not added automatically.

@linlingao Please review

  1. STM32F207ZG was added few years back. We can also use the version that is currently on master and check separately why the update does not provide sector information.

Note, there is a conflict now :/

@JanneKiiskila
Copy link
Contributor Author

JanneKiiskila commented Oct 18, 2019

The Keil CMSIS-pack file has this for the

        <!-- *************************  Device 'STM32F207ZG'  ***************************** -->
        <device Dname="STM32F207ZG">
          <memory id="IROM1"                               start="0x08000000" size="0x00100000" startup="1" default="1"/>
          <memory id="IRAM1"                               start="0x20000000" size="0x00020000" init   ="0" default="1"/>
          <algorithm name="CMSIS/Flash/STM32F2xx_1024.FLM" start="0x08000000" size="0x00100000"             default="1"/>
          <algorithm name="CMSIS/Flash/STM32F2xx_OPT.FLM"  start="0x1FFFC000" size="0x00000010"             default="0"/>
          <algorithm name="CMSIS/Flash/STM32F2xx_OTP.FLM"  start="0x1FFF7800" size="0x00000210"             default="0"/>
          <feature type="ADC"           n="24"      m="12"/>
          <feature type="IOs"           n="114"/>
          <variant Dvariant="STM32F207ZGTx"> <feature type="QFP" n="144"/> </variant>
        </device>

The current index.json under tools/arm_pack_manager has this information:

        "name": "STM32F207ZGTx", 
        "processor": {
            "Symmetric": {
                "core": "CortexM3", 
                "fpu": "None", 
                "mpu": "Present", 
                "units": 1
            }
        }, 
        "sectors": [
            [
                134217728, 
                16384
            ], 
            [
                134283264, 
                65536
            ], 
            [
                134348800, 
                131072
            ], 
            [
                536836096, 
                528
            ], 
            [
                536854528, 
                16
            ]
        ], 

So, the information seems to be essentially there, but it is not parsed out somehow.

@JanneKiiskila
Copy link
Contributor Author

I think it's likely better to update only the sections that need updating (though one horribly large .json file is not cool for that, in the longer term we should probably consider splitting the json file into vendor specific files).

JanneKiiskila pushed a commit to JanneKiiskila/mbed-os that referenced this pull request Oct 18, 2019
Manually replaced the existing STM32H7 section and replaced it with the
context of updated `index.json` that pulled in the Keil packs available
today, as of 18th October, 2019.

See related PR; ARMmbed#11707
@JanneKiiskila
Copy link
Contributor Author

Closing this one out, better to do it manually after all (which is a pain, editing megabytes long JSON file is not really my idea of fun). See new PR; #11709

@JanneKiiskila JanneKiiskila deleted the cmsis_pack_update-2019-10-18 branch October 18, 2019 11:14
@linlingao
Copy link
Contributor

We've been editing this file manually. I was told Keil is not committed to hosting CMSIS packs so relying on Keil is no longer sustainable.

JanneKiiskila pushed a commit to JanneKiiskila/mbed-os that referenced this pull request Oct 31, 2019
Manually replaced the existing STM32H7 section and replaced it with the
context of updated `index.json` that pulled in the Keil packs available
today, as of 18th October, 2019.

See related PR; ARMmbed#11707
JanneKiiskila pushed a commit to JanneKiiskila/mbed-os that referenced this pull request Nov 1, 2019
Manually replaced the existing STM32H7 section and replaced it with the
context of updated `index.json` that pulled in the Keil packs available
today, as of 18th October, 2019.

See related PR; ARMmbed#11707
jeromecoutant pushed a commit to jeromecoutant/mbed that referenced this pull request Nov 4, 2019
Manually replaced the existing STM32H7 section and replaced it with the
context of updated `index.json` that pulled in the Keil packs available
today, as of 18th October, 2019.

See related PR; ARMmbed#11707
JanneKiiskila pushed a commit to JanneKiiskila/mbed-os that referenced this pull request Nov 4, 2019
Manually replaced the existing STM32H7 section and replaced it with the
context of updated `index.json` that pulled in the Keil packs available
today, as of 18th October, 2019.

See related PR; ARMmbed#11707
adbridge pushed a commit that referenced this pull request Nov 19, 2019
Manually replaced the existing STM32H7 section and replaced it with the
context of updated `index.json` that pulled in the Keil packs available
today, as of 18th October, 2019.

See related PR; #11707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants