-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aitutu: Updating the workload to add support for the Samsung devices … #989
base: master
Are you sure you want to change the base?
Conversation
Please fix the commit message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a description in the commit message of what popup this is dismissing on Samsung devices?
@@ -60,14 +60,19 @@ public void extractResults() throws Exception { | |||
public void clearPopups() throws Exception { | |||
UiSelector selector = new UiSelector(); | |||
|
|||
UiObject next = mDevice.findObject(selector.textContains("NEXT") | |||
.className("android.widget.Button")); | |||
next.waitForExists(60000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
60 seconds seems to be a very long timeout for something that is only present on some devices. Is there an extra 0 here?
if (next.exists()){ | ||
next.click(); | ||
} | ||
|
||
UiObject cancel = mDevice.findObject(selector.textContains("CANCEL") | ||
.className("android.widget.Button")); | ||
cancel.waitForExists(60000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this also be changed?
…that do not seem to dismiss the next button like other devices.