Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEBUGINFRA-724] Migrate to GitHub Actions #466

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

sm-powell
Copy link
Contributor

@sm-powell sm-powell commented May 13, 2024

Migrate to GitHub Actions from Jenkins.

Two workflows have been created:

Migrate to GutHub Actions from Jenkins
@sm-powell sm-powell requested a review from solidpixel May 13, 2024 10:51
@solidpixel solidpixel changed the title [DEBUGINFRA-724] Migrate to GutHub Actions [DEBUGINFRA-724] Migrate to GitHub Actions May 13, 2024
Copy link

@spcaipers-arm spcaipers-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good, there are opportunities to reduce the code by using a matrix job. I see many repeated steps across the jobs.


- name: Build R
run: |
export CXX=clang++

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use a job-level env var for that as an alternative.

- name: Get Python modules
run: |
python -m pip install --upgrade pip
pip install numpy Pillow

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can be more git-friendly by:

pip install \
  numpy \
  Pillow

- name: Get Python modules
run: |
python -m pip install --upgrade pip
pip install numpy Pillow

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@sm-powell
Copy link
Contributor Author

Applied standard repo settings: https://confluence.arm.com/display/DTP/GitHub+Repo+Settings

@solidpixel solidpixel merged commit 773e2b1 into main May 15, 2024
4 checks passed
@solidpixel solidpixel deleted the github_workflow branch May 15, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants