Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes for warnings in 2D #855

Merged
merged 9 commits into from
Oct 8, 2024

Conversation

baperry2
Copy link
Contributor

@baperry2 baperry2 commented Oct 7, 2024

Pulls in fixes from AMReX-Combustion/PelePhysics#534 and makes a couple changes in PeleC:

  • Enable the extruded_triangles EB geometry in 2D
  • Add some #ifdef AMREX_SPACEDIM == 3 in Diffterm to avoid a warning about out of bounds array access (the offending case is never actually used in 2D, but the compiler doesn't know that)

@baperry2 baperry2 requested a review from marchdf October 7, 2024 23:29
@baperry2 baperry2 enabled auto-merge (squash) October 8, 2024 18:00
@baperry2 baperry2 merged commit c6e5e30 into AMReX-Combustion:development Oct 8, 2024
13 checks passed
@baperry2 baperry2 deleted the intvect-fixes branch October 8, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants