Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for a singular matrix in SDC Newton solve #2903

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Check for a singular matrix in SDC Newton solve #2903

merged 1 commit into from
Jul 8, 2024

Conversation

yut23
Copy link
Collaborator

@yut23 yut23 commented Jul 6, 2024 •
edited
Loading

PR summary

This checks the result of RHS::dgefa() for templated networks.

PR motivation

Needs AMReX-Astro/Microphysics#1603.

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@yut23 yut23 changed the title Update RHS::dgefa call for AMReX-Astro/Microphysics#1603 Check for a singular matrix in SDC Newton solve Jul 6, 2024
@zingale zingale merged commit 79841a7 into AMReX-Astro:development Jul 8, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale zingale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yut23 @zingale